fix(datetimefield): fix name of the type and validity check

Signed-off-by: Thierry Bugier <tbugier@teclib.com>

Author: btry

inc/fields/datetimefield.class.php

@@ -96,7 +96,7 @@ public function isValid() {
    }
 
    public static function getName() {
-      return __('Datetime', 'formcreator');
+      return __('Date & time', 'formcreator');
    }
 
    public static function getPrefs() {
@@ -155,7 +155,8 @@ public function parseAnswerValues($input) {
          return false;
       }
 
-      if (DateTime::createFromFormat("Y-m-d H:i", $input[$key]) === false) {
+      if ($input[$key] != ''
+         && DateTime::createFromFormat("Y-m-d H:i", $input[$key]) === false) {
          return false;
       }
 

tests/suite-unit/PluginFormcreatorDatetimeField.php

@@ -156,8 +156,8 @@ public function providerparseAnswerValues() {
             'input' => [
                'formcreator_field_1' => ''
             ],
-            'expected' => false,
-            'expectedValue' => null,
+            'expected' => true,
+            'expectedValue' => ' ',
          ],
          [
             'id' => '1',