fix(glpiselectfield): search itemtype in wrong locatin

data migrated to own column

Author: btry

inc/field/dropdownfield.class.php

@@ -914,22 +914,6 @@ public function getSubItemtype() {
       return $this->question->fields['itemtype'];
    }
 
-   /**
-    * Get the itemtype of the item to show for the given values
-    *
-    * @param string $values json or raw string
-    *
-    * @return string
-    */
-   public static function getSubItemtypeForValues($values) {
-      $decodedValues = json_decode($values, JSON_OBJECT_AS_ARRAY);
-      if ($decodedValues === null) {
-         return $values;
-      }
-
-      return $decodedValues['itemtype'];
-   }
-
    /**
     * get HTML code to show entity restriction policy
     * @return string HTML code

inc/field/glpiselectfield.class.php

@@ -212,7 +212,7 @@ public function getAvailableValues(): array {
 
    public function equals($value): bool {
       $value = html_entity_decode($value);
-      $itemtype = $this->getSubItemtypeForValues($this->question->fields['values']);
+      $itemtype = $this->getSubItemtype();
       $item = new $itemtype();
       if ($item->isNewId($this->value)) {
          return ($value === '');
@@ -229,7 +229,7 @@ public function notEquals($value): bool {
 
    public function greaterThan($value): bool {
       $value = html_entity_decode($value);
-      $itemtype = $this->getSubItemtypeForValues($this->question->fields['values']);
+      $itemtype = $this->getSubItemtype();
       $item = new $itemtype();
       if (!$item->getFromDB($this->value)) {
          throw new ComparisonException('Item not found for comparison');