fix(dropdown): change to ticket category

changing from an other droptown causes php warnings

also add upgrade code

Signed-off-by: btry <tbugier@teclib.com>

Author: btry

inc/question.class.php

@@ -961,7 +961,9 @@ function plugin_formcreator_hideAllParameters() {
       ];
       dropdown::showFromArray('show_ticket_categories', $ticketCategoriesOptions, [
          'rand'  => $rand,
-         'value' => $decodedValues['show_ticket_categories']
+         'value' => isset($decodedValues['show_ticket_categories'])
+                    ? $decodedValues['show_ticket_categories']
+                    : 'both'
       ]);
       echo '</td>';
       echo '<td>';
@@ -972,7 +974,9 @@ function plugin_formcreator_hideAllParameters() {
       echo '<td>';
       dropdown::showNumber('show_ticket_categories_depth', [
                            'rand'  => $rand,
-                           'value' => $decodedValues['show_ticket_categories_depth'],
+                           'value' => isset($decodedValues['show_ticket_categories_depth'])
+                                      ? $decodedValues['show_ticket_categories_depth']
+                                      : 0,
                            'min' => 1,
                            'max' => 16,
                            'toadd' => [0 => __('No limit', 'formcreator')],

install/update_2.6_2.7.php

@@ -88,4 +88,24 @@ function plugin_formcreator_update_2_7(Migration $migration) {
       $id = $row['id'];
       $DB->query("UPDATE `glpi_plugin_formcreator_questions` SET `name`='$name' WHERE `id` = '$id'");
    }
+
+   // Add properties for dropdown of ticket categories
+   $request = [
+      'FROM'   => 'glpi_plugin_formcreator_questions',
+      'WHERE'  => [
+         'fieldtype' => 'dropdown'
+      ],
+   ];
+   foreach ($DB->request($request) as $row) {
+      $values = json_decode($row['values'], true);
+      if (!isset($values['show_ticket_categories'])) {
+         $values['show_ticket_categories'] = 'both';
+      }
+      if (!isset($values['show_ticket_categories_depth'])) {
+         $values['show_ticket_categories_depth'] = '0';
+      }
+      $id = $row['id'];
+      $values = json_encode($values);
+      $DB->query("UPDATE `glpi_plugin_formcreator_questions` SET `values`='$values' WHERE `id` = '$id'");
+   }
 }