fix(install): inconsistency in fresh 2.6.0 install

fix #822

Author: btry

install/mysql/plugin_formcreator_empty.sql

@@ -212,7 +212,7 @@ CREATE TABLE IF NOT EXISTS `glpi_plugin_formcreator_targettickets` (
   `tag_type` enum('none','questions','specifics','questions_and_specific','questions_or_specific') NOT NULL DEFAULT 'none',
   `tag_questions` varchar(255) NOT NULL,
   `tag_specifics` varchar(255) NOT NULL,
-  `category_rule` enum('none','answer') NOT NULL DEFAULT 'none',
+  `category_rule` enum('none','specific','answer') NOT NULL DEFAULT 'none',
   `category_question` int(11) NOT NULL DEFAULT '0',
   PRIMARY KEY (`id`),
   INDEX `tickettemplates_id` (`tickettemplates_id`)

install/update_2.5_2.6.php

@@ -109,6 +109,23 @@ function plugin_formcreator_update_2_6(Migration $migration) {
    }
    unset($obj);
 
+   $enum_category_rule      = "'".implode("', '", array_keys(PluginFormcreatorTargetTicket::getEnumCategoryRule()))."'";
+   $table = 'glpi_plugin_formcreator_targettickets';
+   if (!$DB->fieldExists($table, 'category_rule', false)) {
+      $query = "ALTER TABLE `$table`
+                ADD `category_rule` ENUM($enum_category_rule) NOT NULL DEFAULT 'none' AFTER `tag_specifics`;";
+      $DB->query($query) or plugin_formcreator_upgrade_error($migration);
+   } else {
+      $current_enum_category_rule = PluginFormcreatorCommon::getEnumValues($table, 'category_rule');
+      if (count($current_enum_category_rule) != count(PluginFormcreatorTargetTicket::getEnumCategoryRule())) {
+         $query = "ALTER TABLE `$table`
+                   CHANGE COLUMN `category_rule` `category_rule`
+                   ENUM($enum_category_rule)
+                   NOT NULL DEFAULT 'none'";
+         $DB->query($query) or plugin_formcreator_upgrade_error($migration);
+      }
+   }
+
    $table = 'glpi_plugin_formcreator_items_targetchanges';
    $enum_urgency_rule       = "'".implode("', '", array_keys(PluginFormcreatorTargetChange::getEnumUrgencyRule()))."'";
    $enum_category_rule      = "'".implode("', '", array_keys(PluginFormcreatorTargetChange::getEnumCategoryRule()))."'";