fix: log more errors, and update obsolete error logging

Author: btry

inc/fields.class.php

@@ -202,7 +202,7 @@ public static function isVisible(PluginFormcreatorConditionnableInterface $item,
 
             default:
                // This should not happen : inconsistency in the database
-               Toolbox::logError("Inconsistency detected in conditions: show rule set but no condition found, $itemtype ID=$itemId");
+               trigger_error("Inconsistency detected in conditions: show rule set but no condition found, $itemtype ID=$itemId", E_USER_WARNING);
                self::$visibility[$itemtype][$itemId] = $getParentVisibility();
                return self::$visibility[$itemtype][$itemId];
                break;

inc/issue.class.php

@@ -817,21 +817,25 @@ public static function giveItem($itemtype, $option_id, $data, $num) {
          case "glpi_plugin_formcreator_issues.name":
             $name = $data[$num][0]['name'];
             $subItemtype = $data['raw']['itemtype'];
+            $content = '';
             switch ($subItemtype) {
                case Ticket::class:
                   $ticket = new Ticket();
-                  $ticket->getFromDB($id);
+                  if (!$ticket->getFromDB($id)) {
+                     trigger_error(sprintf("Ticket ID %s not found", $id), E_USER_WARNING);
+                     break;
+                  }
                   $content = $ticket->fields['content'];
                   break;
 
                case PluginFormcreatorFormAnswer::class:
                   $formAnswer = PluginFormcreatorCommon::getFormAnswer();
-                  $formAnswer->getFromDB($id);
+                  if (!$formAnswer->getFromDB($id)) {
+                     trigger_error(sprintf("Formanswer ID %s not found", $id), E_USER_WARNING);
+                     break;
+                  }
                   $content = $formAnswer->parseTags($formAnswer->getFullForm());
                   break;
-
-               default:
-                  $content = '';
             }
             $link = self::getFormURLWithID($data['id']);
 

inc/ldapdropdown.class.php

@@ -139,7 +139,7 @@ public static function getDropdownValue($post, $json = true) {
             $limitexceeded = in_array(ldap_errno($ds), [4, 11]);
 
             if ($limitexceeded) {
-               Toolbox::logError("LDAP size limit exceeded");
+               trigger_error("LDAP size limit exceeded", E_USER_ERROR);
             }
 
             unset($entries['count']);

inc/targetticket.class.php

@@ -1071,11 +1071,11 @@ protected function setTargetType(array $data, PluginFormcreatorFormAnswer $forma
             if (isset($type['answer']) && ctype_digit($type['answer'])) {
                $type = $type['answer'];
             } else {
-               // Invalid value. Maybe the questin is not compatible.
+               // Invalid value. Maybe the question is not compatible.
                trigger_error(sprintf("Attempt to set the type of a ticket from an incompatible question. Check the target ticket %s of the form ID=%s",
                   $this->fields['name'],
                   $this->getForm()->getID()
-               ));
+               ), E_USER_ERROR);
                $type = null;
             }
             break;
@@ -1208,7 +1208,7 @@ protected function setTargetAssociatedItem(array $data, PluginFormcreatorFormAns
             $associateQuestion = $this->fields['associate_question'];
             $question = new PluginFormcreatorQuestion();
             if (!$question->getFromDB($associateQuestion)) {
-               Toolbox::logError(sprintf("Question ID %s not found and should be used in target ticket ID %s", $associateQuestion, $this-getID()));
+               trigger_error(sprintf("Question ID %s not found and should be used in target ticket ID %s", $associateQuestion, $this->getID()), E_USER_ERROR);
                break;
             }
             /** @var  GlpiPlugin\Formcreator\Field\DropdownField */