fix(install): fix inconsistencies in install process"

Author: btry

install/install.php

@@ -19,8 +19,8 @@ public function install(Migration $migration) {
       $this->configureExistingEntities();
       $this->createRequestType();
       $this->createDefaultDisplayPreferences();
+      $this->createCronTasks();
       $this->createNotifications();
-
       Config::setConfigurationValues('formcreator', ['schema_version' => PLUGIN_FORMCREATOR_SCHEMA_VERSION]);
 
       return true;
@@ -64,6 +64,7 @@ public function upgrade(Migration $migration) {
       $this->configureExistingEntities();
       $this->createRequestType();
       $this->createDefaultDisplayPreferences();
+      $this->createCronTasks();
       Config::setConfigurationValues('formcreator', ['schema_version' => PLUGIN_FORMCREATOR_SCHEMA_VERSION]);
 
       return true;
@@ -439,4 +440,16 @@ public function uninstall() {
       $config = new Config();
       $config->deleteByCriteria(['context' => 'formcreator']);
    }
+
+   /**
+    * Create cron tasks
+    */
+   protected function createCronTasks() {
+      CronTask::Register(PluginFormcreatorIssue::class, 'SyncIssues', HOUR_TIMESTAMP,
+         [
+            'comment'   => __('Formcreator - Sync service catalog issues', 'formcreator'),
+            'mode'      => CronTask::MODE_EXTERNAL
+         ]
+      );
+   }
 }

tests/0000_Install/PluginInstallTest.php

@@ -49,12 +49,15 @@ protected function setupGLPI() {
       $CFG_GLPI = $settings + $CFG_GLPI;
    }
 
+   /**
+    * @engine inline
+    */
    public function testInstallPlugin() {
       global $DB;
 
       $this->setupGLPI();
 
-      $this->assertTrue($DB->connected, "Problem connecting to the Database");
+      $this->assertTrue($DB->connected, 'Problem connecting to the Database');
 
       $this->login('glpi', 'glpi');
 
@@ -63,12 +66,12 @@ public function testInstallPlugin() {
       $config->deleteByCriteria(array('context' => 'formcreator'));
 
       // Drop tables of the plugin if they exist
-      $query = "SHOW TABLES";
+      $query = 'SHOW TABLES';
       $result = $DB->query($query);
       while ($data = $DB->fetch_array($result)) {
 
-         if (strstr($data[0], "glpi_plugin_formcreator") !== false) {
-            $DB->query("DROP TABLE ".$data[0]);
+         if (strstr($data[0], 'glpi_plugin_formcreator') !== false) {
+            $DB->query('DROP TABLE '.$data[0]);
          }
       }
 
@@ -82,15 +85,21 @@ public function testInstallPlugin() {
       ob_end_clean();
 
       $PluginDBTest = new PluginDB();
-      $PluginDBTest->checkInstall("formcreator", "install");
+      $PluginDBTest->checkInstall('formcreator', 'install');
 
+      // Check the version of the schema is saved
       $config = Config::getConfigurationValues('formcreator');
       $this->assertArrayHasKey('schema_version', $config);
-      $this->assertEquals($config['schema_version'], PLUGIN_FORMCREATOR_SCHEMA_VERSION);
+      $this->assertEquals(PLUGIN_FORMCREATOR_SCHEMA_VERSION, $config['schema_version']);
+
+      // Check the cron task is created
+      $cronTask = new CronTask();
+      $cronTask->getFromDBbyName(PluginFormcreatorIssue::class, 'SyncIssues');
+      $this->assertFalse($cronTask->isNewItem());
 
       // Enable the plugin
       $plugin->activate($plugin->fields['id']);
-      $this->assertTrue($plugin->isActivated("formcreator"), "Cannot enable the plugin");
+      $this->assertTrue($plugin->isActivated('formcreator'), 'Cannot enable the plugin');
 
    }
 }