fix(formlist): prevent php deprecation

conversion from bool to array because getMenuContent may return false

Author: btry

inc/formlist.class.php

@@ -46,12 +46,11 @@ public static function getTypeName($nb = 0) {
       return _n('Form', 'Forms', $nb, 'formcreator');
    }
 
-   public static function getMenuContent() {
-      $menu = parent::getMenuContent();
-      $menu['title'] = static::getTypeName(Session::getPluralNumber());
-      $menu['page'] = PluginFormcreatorFormList::getSearchURL(false);
-      $menu['icon'] = 'fas fa-edit';
+   public static function canView() {
+      return (PluginFormcreatorForm::countAvailableForm() > 0);
+   }
 
-      return $menu;
+   public static function getIcon() {
+      return 'fas fa-edit';
    }
 }

setup.php

@@ -355,10 +355,7 @@ function plugin_formcreator_hook() {
       return;
    }
 
-   // If user have acces to one form or more, add link
-   if (PluginFormcreatorForm::countAvailableForm() > 0) {
-      $PLUGIN_HOOKS['menu_toadd']['formcreator']['helpdesk'] = PluginFormcreatorFormlist::class;
-   }
+   $PLUGIN_HOOKS['menu_toadd']['formcreator']['helpdesk'] = PluginFormcreatorFormlist::class;
 
    // Massive Action definition
    $PLUGIN_HOOKS['use_massive_action']['formcreator'] = 1;