fix(form): don't access deleted forms

btry · btry · commit 6169412d1e6b · 2019-10-10T13:47:57.000+02:00
Signed-off-by: Thierry Bugier &lt;tbugier@teclib.com&gt;
diff --git a/front/formdisplay.php b/front/formdisplay.php
@@ -47,7 +47,7 @@
    && is_numeric($_REQUEST['id'])) {
 
    if ($form->getFromDB((int) $_REQUEST['id'])) {
-      if ($form->fields['is_active'] == '0') {
+      if ($form->fields['is_active'] == '0' || $form->fields['is_deleted'] != '0') {
          Html::displayNotFoundError();
       }
       if ($form->fields['access_rights'] != PluginFormcreatorForm::ACCESS_PUBLIC) {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@`
`47`	`47`	`&& is_numeric($_REQUEST['id'])) {`
`48`	`48`
`49`	`49`	`if ($form->getFromDB((int) $_REQUEST['id'])) {`
`50`		`- if ($form->fields['is_active'] == '0') {`
	`50`	`+ if ($form->fields['is_active'] == '0' \|\| $form->fields['is_deleted'] != '0') {`
`51`	`51`	`Html::displayNotFoundError();`
`52`	`52`	`}`
`53`	`53`	`if ($form->fields['access_rights'] != PluginFormcreatorForm::ACCESS_PUBLIC) {`