fix(targetticket): possible SQL error

With a form configured to set location of a target ticket from a question, changing the question type to a text field causes attempt to set location from a string
instead if an ID. If the string contains a single quote, then the INSERT query is broken. This check the value is an integer. If not, lets ignore the value.

May need to lock questions when they are linked to a target.

Author: btry

inc/targetticket.class.php

@@ -953,6 +953,7 @@ public function save(PluginFormcreatorFormAnswer $formanswer) {
    protected function setTargetLocation($data, $formanswer) {
       global $DB;
 
+      $location = null;
       switch ($this->fields['location_rule']) {
          case self::LOCATION_RULE_ANSWER:
             $location = $DB->request([
@@ -963,13 +964,13 @@ protected function setTargetLocation($data, $formanswer) {
                   'plugin_formcreator_questions_id'   => $this->fields['location_question']
                ]
             ])->current();
-            $location = $location['answer'];
+            if (ctype_digit($location['answer'])) {
+               $location = $location['answer'];
+            }
             break;
          case self::LOCATION_RULE_SPECIFIC:
             $location = $this->fields['location_question'];
             break;
-         default:
-            $location = null;
       }
       if (!is_null($location)) {
          $data['locations_id'] = $location;