fix(issue): php warnings in service catalog

also fixes compatibility with GLPI 9.3 and 9.4

Signed-off-by: btry <tbugier@teclib.com>

Author: btry

inc/form_answer.class.php

@@ -269,8 +269,7 @@ public static function getSpecificValueToDisplay($field, $values, array $options
       switch ($field) {
          case 'status' :
             $output = '<img src="' . $CFG_GLPI['root_doc'] . '/plugins/formcreator/pics/' . $values[$field] . '.png"
-                         alt="' . __($values[$field], 'formcreator') . '" title="' . __($values[$field], 'formcreator') . '" /> '
-                      . __($values[$field], 'formcreator');
+                         alt="' . __($values[$field], 'formcreator') . '" title="' . __($values[$field], 'formcreator') . '" /> ';
             return $output;
             break;
       }

inc/issue.class.php

@@ -277,12 +277,16 @@ public function getTicketsForDisplay($options) {
       return $item;
    }
 
-      /**
+   /**
     * Define search options for forms
     *
     * @return Array Array of fields to show in search engine and options for each fields
     */
    public function getSearchOptionsNew() {
+      return $this->rawSearchOptions();
+   }
+
+   public function rawSearchOptions() {
       $tab = [];
 
       $tab[] = [
@@ -493,8 +497,11 @@ public static function giveItem($itemtype, $option_id, $data, $num) {
             switch ($data['raw']['sub_itemtype']) {
                case 'Ticket':
                   $status = Ticket::getStatus($data['raw']["ITEM_$num"]);
-                  return "<img src='".Ticket::getStatusIconURL($data['raw']["ITEM_$num"])."'
-                               alt=\"$status\" title=\"$status\">&nbsp;$status";
+                  if (version_compare(PluginFormcreatorCommon::getGlpiVersion(), '9.3') < 0) {
+                     return "<img src='".Ticket::getStatusIconUrl($data['raw']["ITEM_$num"])."'
+                                 alt=\"$status\" title=\"$status\">&nbsp;$status";
+                  }
+                  return Ticket::getStatusIcon($data['raw']["ITEM_$num"]);
                   break;
 
                case 'PluginFormcreatorForm_Answer':