From 4a8bcfb8872404e5ffa6e0ce60c8b7b2b14c028a Mon Sep 17 00:00:00 2001 From: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Date: Sun, 25 Oct 2026 15:10:40 -0700 Subject: [PATCH] chore(lint): enforce schemaStructWithTag --- packages/effect-acp/src/agent.test.ts | 5 +---- packages/effect-acp/src/client.test.ts | 5 +---- tsconfig.base.json | 1 + 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/effect-acp/src/agent.test.ts b/packages/effect-acp/src/agent.test.ts index 95f9e2ec2f1dd..47211d54b2b84 100644 --- a/packages/effect-acp/src/agent.test.ts +++ b/packages/effect-acp/src/agent.test.ts @@ -37,10 +37,7 @@ const ExtRequest = jsonRpcRequest("x/test", Schema.Struct({ hello: Schema.String const ExtResponse = jsonRpcResponse(Schema.Struct({ ok: Schema.Boolean })); const DieResponse = Schema.Struct({ id: Schema.Number, - error: Schema.Struct({ - _tag: Schema.Literal("Cause"), - data: Schema.Tuple([Schema.Struct({ _tag: Schema.Literal("Die") })]), - }), + error: Schema.TaggedStruct("Cause", { data: Schema.Tuple([Schema.TaggedStruct("Die", {})]) }), }); const decodeRequestPermissionRequest = Schema.decodeEffect( Schema.fromJsonString(RequestPermissionRequest), diff --git a/packages/effect-acp/src/client.test.ts b/packages/effect-acp/src/client.test.ts index 8dcf23b7272a2..71f00c0f71b3c 100644 --- a/packages/effect-acp/src/client.test.ts +++ b/packages/effect-acp/src/client.test.ts @@ -53,10 +53,7 @@ const PermissionResponse = jsonRpcResponse(AcpSchema.RequestPermissionResponse); const ErrorResponse = Schema.Struct({ id: Schema.String, error: Schema.Unknown }); const DieResponse = Schema.Struct({ id: Schema.String, - error: Schema.Struct({ - _tag: Schema.Literal("Cause"), - data: Schema.Tuple([Schema.Struct({ _tag: Schema.Literal("Die") })]), - }), + error: Schema.TaggedStruct("Cause", { data: Schema.Tuple([Schema.TaggedStruct("Die", {})]) }), }); const decodePromptRequestLine = Schema.decodeEffect(Schema.fromJsonString(PromptRequest)); const XAiPromptCompleteNotification = jsonRpcNotification( diff --git a/tsconfig.base.json b/tsconfig.base.json index 1dfdbd6634245..f6d10a4182247 100644 --- a/tsconfig.base.json +++ b/tsconfig.base.json @@ -24,6 +24,7 @@ "namespaceImportPackages": ["@effect/platform-node", "effect"], "effectFn": ["span", "inferred-span", "suggested-span"], "diagnosticSeverity": { + "schemaStructWithTag": "error", "preferTypedSchemaDecoder": "error", "catchUnfailableEffect": "error", "raceFirstWithSleepToTimeout": "error",