From 7fb987d1d5a6bff7895c0fa6702022c704674137 Mon Sep 17 00:00:00 2001 From: Craig Davison <5341072+davisonio@users.noreply.github.com> Date: Sat, 24 Oct 2026 15:04:04 +0800 Subject: [PATCH 1/2] fix(desktop): nightly update notes no longer list the Full Changelog link as a change --- apps/desktop/src/updates/releaseNotes.test.ts | 40 +++++++++++++++++++ apps/desktop/src/updates/releaseNotes.ts | 4 +- 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/apps/desktop/src/updates/releaseNotes.test.ts b/apps/desktop/src/updates/releaseNotes.test.ts index 008a83eab03db..947b5acdb4024 100644 --- a/apps/desktop/src/updates/releaseNotes.test.ts +++ b/apps/desktop/src/updates/releaseNotes.test.ts @@ -173,4 +173,44 @@ describe("normalizeDesktopUpdateReleaseNotes", () => { omittedReleaseCount: 0, }); }); + + it("ignores the Full Changelog paragraph that ends GitHub's generated notes", () => { + const fullChangelog = (from: string, to: string) => + `

Full Changelog: v${from}...v${to}

`; + const result = normalizeDesktopUpdateReleaseNotes( + [ + { + version: "0.1.3-nightly.20261024.3604", + note: fullChangelog("0.1.3-nightly.20261023.3592", "0.1.3-nightly.20261024.3604"), + }, + { + version: "0.1.3-nightly.20261023.3592", + note: + "

What's Changed

\n\n" + + fullChangelog("0.1.3-nightly.20261023.3579", "0.1.3-nightly.20261023.3592"), + }, + ], + "0.1.3-nightly.20261024.3604", + "nightly", + ); + + expect(result).toEqual({ + releaseNotes: [ + { + version: "0.1.3-nightly.20261023.3592", + items: [ + "Full Changelog: links open in the browser in #3", + "fix(web): B by @b in #2", + "fix(web): A by @a in #1", + ], + totalItems: 3, + }, + ], + omittedReleaseCount: 0, + }); + }); }); diff --git a/apps/desktop/src/updates/releaseNotes.ts b/apps/desktop/src/updates/releaseNotes.ts index ef6d217299d09..fe6e2a1bede24 100644 --- a/apps/desktop/src/updates/releaseNotes.ts +++ b/apps/desktop/src/updates/releaseNotes.ts @@ -88,7 +88,9 @@ function isIgnoredReleaseNoteLine(line: string): boolean { normalized === "what's changed" || normalized === "whats changed" || normalized.startsWith("compare: ") || - normalized.includes("/compare/") + normalized.includes("/compare/") || + // The feed's HTML footer loses its compare URL to stripMarkup, leaving only the range. + /^full changelog: \S+\.\.\.\S+$/.test(normalized) ); } From 7b95cfef401199373e0ef28fc1d48073d71a8019 Mon Sep 17 00:00:00 2001 From: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Date: Fri, 30 Oct 2026 19:45:01 +0000 Subject: [PATCH 2/2] test(desktop): release notes expectation includes the release date --- apps/desktop/src/updates/releaseNotes.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/desktop/src/updates/releaseNotes.test.ts b/apps/desktop/src/updates/releaseNotes.test.ts index 6a44567b8ebc5..30db8274c208f 100644 --- a/apps/desktop/src/updates/releaseNotes.test.ts +++ b/apps/desktop/src/updates/releaseNotes.test.ts @@ -266,6 +266,7 @@ describe("normalizeDesktopUpdateReleaseNotes", () => { "fix(web): B by @b in #2", "fix(web): A by @a in #1", ], + releasedAt: "2026-10-23", totalItems: 3, }, ],