From 72d0b8d88bd10061fe6dd6d11b3c540f055d44f9 Mon Sep 17 00:00:00 2001 From: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Date: Fri, 16 Oct 2026 21:34:21 -0700 Subject: [PATCH] perf(web): the provider update dismissal hook compiles without manual memoization Co-Authored-By: Claude Opus 5.5 --- apps/web/src/providerUpdateDismissal.ts | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/apps/web/src/providerUpdateDismissal.ts b/apps/web/src/providerUpdateDismissal.ts index 28789152b34c..d04f16e8930c 100644 --- a/apps/web/src/providerUpdateDismissal.ts +++ b/apps/web/src/providerUpdateDismissal.ts @@ -1,4 +1,3 @@ -import { useCallback, useMemo } from "react"; import * as Schema from "effect/Schema"; import { getLocalStorageItem, setLocalStorageItem, useLocalStorage } from "./hooks/useLocalStorage"; @@ -70,21 +69,18 @@ export function useDismissedProviderUpdateNotificationKeys() { ); const dismissedKeys = dismissals.keys; - const dismissedKeySet = useMemo(() => new Set(dismissedKeys), [dismissedKeys]); + const dismissedKeySet = new Set(dismissedKeys); - const dismissNotificationKey = useCallback( - (key: string) => { - const trimmedKey = key.trim(); - if (trimmedKey.length === 0 || dismissedKeySet.has(trimmedKey)) { - return; - } + const dismissNotificationKey = (key: string) => { + const trimmedKey = key.trim(); + if (trimmedKey.length === 0 || dismissedKeySet.has(trimmedKey)) { + return; + } - setDismissals({ - keys: [...dismissedKeys, trimmedKey], - }); - }, - [dismissedKeySet, dismissedKeys, setDismissals], - ); + setDismissals({ + keys: [...dismissedKeys, trimmedKey], + }); + }; return { dismissedNotificationKeys: dismissedKeySet,