Fix Clerk bridge initialization before instance lock

Move Effect.acquireRelease for createDesktopClerkBridge back inside
configure, after requestSingleInstanceLock succeeds. This prevents a
second app instance from opening Clerk storage before it discovers it
lost the lock and quits, which could cause storage corruption or flaky
auth on concurrent launches.

Author: cursoragent

apps/desktop/src/app/DesktopClerk.test.ts

@@ -1,6 +1,7 @@
 import { assert, describe, it } from "@effect/vitest";
 import * as Effect from "effect/Effect";
 import * as Layer from "effect/Layer";
+import * as Option from "effect/Option";
 import { vi } from "vite-plus/test";
 
 const { createClerkBridgeMock, storageAdapter, storageMock } = vi.hoisted(() => ({
@@ -24,22 +25,41 @@ vi.mock("@clerk/electron/storage", () => ({
 import { createDesktopClerkBridge } from "./DesktopClerk.ts";
 import * as DesktopClerk from "./DesktopClerk.ts";
 import * as DesktopEnvironment from "./DesktopEnvironment.ts";
+import * as ElectronApp from "../electron/ElectronApp.ts";
+import * as ElectronWindow from "../electron/ElectronWindow.ts";
 
 describe("DesktopClerk", () => {
-  it.effect("acquires and releases the SDK bridge with the layer", () => {
+  it.effect("acquires and releases the SDK bridge during configure after instance lock", () => {
     const cleanup = vi.fn();
     storageMock.mockReturnValue(storageAdapter);
     createClerkBridgeMock.mockReturnValue({ cleanup });
     const environment = DesktopEnvironment.DesktopEnvironment.of({
       stateDir: "/tmp/t3-state",
       isDevelopment: true,
     } as unknown as DesktopEnvironment.DesktopEnvironmentShape);
+    const electronApp = ElectronApp.ElectronApp.of({
+      requestSingleInstanceLock: Effect.succeed(true),
+      on: () => Effect.void,
+    } as unknown as ElectronApp.ElectronAppShape);
+    const electronWindow = ElectronWindow.ElectronWindow.of({
+      currentMainOrFirst: Effect.succeed(Option.none()),
+    } as unknown as ElectronWindow.ElectronWindowShape);
 
     return Effect.gen(function* () {
       yield* Effect.scoped(
-        Layer.build(
-          DesktopClerk.layer.pipe(
-            Layer.provide(Layer.succeed(DesktopEnvironment.DesktopEnvironment, environment)),
+        Effect.gen(function* () {
+          const clerk = yield* DesktopClerk.DesktopClerk;
+          assert.equal(createClerkBridgeMock.mock.calls.length, 0);
+          yield* clerk.configure;
+        }),
+      ).pipe(
+        Effect.provide(
+          Layer.mergeAll(
+            DesktopClerk.layer.pipe(
+              Layer.provide(Layer.succeed(DesktopEnvironment.DesktopEnvironment, environment)),
+            ),
+            Layer.succeed(ElectronApp.ElectronApp, electronApp),
+            Layer.succeed(ElectronWindow.ElectronWindow, electronWindow),
           ),
         ),
       );

apps/desktop/src/app/DesktopClerk.ts

@@ -35,10 +35,6 @@ export function createDesktopClerkBridge(stateDir: string, isDevelopment: boolea
 
 const make = Effect.gen(function* () {
   const environment = yield* DesktopEnvironment.DesktopEnvironment;
-  yield* Effect.acquireRelease(
-    Effect.sync(() => createDesktopClerkBridge(environment.stateDir, environment.isDevelopment)),
-    (bridge) => Effect.sync(() => bridge.cleanup()),
-  );
 
   return DesktopClerk.of({
     configure: Effect.gen(function* () {
@@ -52,6 +48,13 @@ const make = Effect.gen(function* () {
         return yield* Effect.interrupt;
       }
 
+      yield* Effect.acquireRelease(
+        Effect.sync(() =>
+          createDesktopClerkBridge(environment.stateDir, environment.isDevelopment),
+        ),
+        (bridge) => Effect.sync(() => bridge.cleanup()),
+      );
+
       yield* electronApp.on("second-instance", () => {
         void runPromise(
           Effect.gen(function* () {