feat(shared): wire Wolverine durable inbox/outbox per ADR-009#58
Merged
Conversation
Configure WolverineFx.Postgresql to persist envelopes in the dedicated `wolverine` schema in the primary application database. The schema is auto-provisioned on startup in Development and Testing via AddResourceSetupOnStartup; production runs a scripted SQL migration. Adds a new ConnectionStrings:Wolverine entry (same database as the modules) and pins Npgsql 9.0.4 centrally to resolve a transitive version conflict surfaced by WolverineFx.Postgresql. No DbContext is enlisted yet — the existing in-memory PublishAsync in Axis.Shared.Infrastructure.Persistence.UnitOfWork stays until each module integrates via .IntegrateWithWolverine() in follow-up PRs. The PROGRESS.md Shared Kernel note reflects this partial state.
📝 WalkthroughWalkthroughWires Wolverine durable inbox/outbox to PostgreSQL ChangesWolverine PostgreSQL Persistence
Sequence DiagramsequenceDiagram
participant Program
participant WolverineConfig
participant PostgreSQL
participant ResourceSetup
Program->>WolverineConfig: Read ConnectionStrings:Wolverine
Program->>WolverineConfig: Configure UseWolverine(...).PersistMessagesWithPostgresql(schema: "wolverine")
WolverineConfig->>PostgreSQL: Store durable inbox/outbox messages
Program->>ResourceSetup: AddResourceSetupOnStartup() if Env ∈ {Development, Testing}
ResourceSetup->>PostgreSQL: Create `wolverine` schema and tables
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/epics/E01-platform-foundation/features/F01-tenant-registration.md`:
- Around line 113-115: The Implementation status callout for US-003 is missing
the "Decisions" line; update the callout block (the one containing
"Implementation status — Domain: …", "Gaps vs spec", and "Deferred (PR `#50`
follow-up)") to add a "Decisions:" entry summarizing the chosen design (e.g.,
durable retry policy deferred to Wolverine persistence per ADR-009, Admin
assignment on verify, and async provisioning via ProvisionTenantMessage handled
by ProvisionTenantHandler), and mention the pending
IdentityDbContext.IntegrateWithWolverine() rollout where relevant so the callout
includes Implementation status, Gaps vs spec, Deferred follow-ups, and Decisions
consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: deb41ffd-016a-4a97-a02d-17a167566d67
📒 Files selected for processing (7)
Directory.Packages.propsdocs/PROGRESS.mddocs/epics/E01-platform-foundation/features/F01-tenant-registration.mdsrc/Axis.Api/Axis.Api.csprojsrc/Axis.Api/Program.cssrc/Axis.Api/appsettings.jsontests/Api/Axis.Api.Tests/Helpers/ApiTestFixture.cs
CI surfaced two issues on PR #58: 1. Integration tests failed with "Failed to setup resource Envelope Storage of type Wolverine — Connection refused at 127.0.0.1:5432". Root cause: `builder.Configuration.GetConnectionString("Wolverine")` was read eagerly into a local before `WebApplicationFactory.ConfigureAppConfiguration` applied the test Testcontainer override. Move the read into the UseWolverine lambda so resolution happens at host-build time against the live ConfigurationManager. 2. CodeRabbit flagged the US-003 callout for missing the `Decisions:` line required by CLAUDE.md's "Definition of done" template. Add the line covering async provisioning dispatch, the `tenant_{orgId:N}` schema-name format, and the planned move to durable Wolverine outbox once IdentityDbContext is enlisted.
WebApplicationFactory.ConfigureAppConfiguration on IWebHostBuilder does not reach the WebApplicationBuilder.Configuration that Program.cs reads during host build (the order is wrong relative to Wolverine's PersistMessagesWithPostgresql call). Setting the connection string as an env var works because the default config provider reads it before the IWebHostBuilder hook runs. The env var is cleared in DisposeAsync to avoid polluting other test fixtures.
EF Core's EnsureCreatedAsync uses a heuristic: if any user table exists in the target database, skip schema creation. Wolverine's AddResourceSetupOnStartup hosted service ran before the fixture's IdentityDbContext.EnsureCreatedAsync call and created wolverine.outgoing_envelopes (and friends) in the default postgres database, so EF Core then skipped creating the OpenIddict tables. Point Wolverine at axis_wolverine_test (alongside the per-module test DBs) so the two schema-creation paths no longer share a database. Production keeps the single-database layout per ADR-009.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/Api/Axis.Api.Tests/Helpers/ApiTestFixture.cs`:
- Line 73: The in-memory configuration for "ConnectionStrings:Wolverine" is
being set to _postgres.GetConnectionString() causing a mismatch with the
environment variable that points to _wolverineConnectionString; update the code
that seeds the in-memory config (in ApiTestFixture where you build the test
configuration / ConfigureAppConfiguration) to use _wolverineConnectionString
instead of calling _postgres.GetConnectionString(), ensuring the in-memory
config key "ConnectionStrings:Wolverine" and the
Environment.SetEnvironmentVariable call both reference the same
_wolverineConnectionString value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 42e60d57-4a6a-49d1-9de5-08b19b8f7ac5
📒 Files selected for processing (1)
tests/Api/Axis.Api.Tests/Helpers/ApiTestFixture.cs
| // during host build, which runs before WebApplicationFactory's | ||
| // ConfigureAppConfiguration hook is applied to builder.Configuration. | ||
| // Set it via env var so the default config provider picks it up. | ||
| Environment.SetEnvironmentVariable("ConnectionStrings__Wolverine", _wolverineConnectionString); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify where Wolverine connection string is consumed and whether this fixture value can override it.
set -euo pipefail
echo "== Locate Wolverine connection string reads =="
rg -n -C3 'ConnectionStrings:Wolverine|GetConnectionString\s*\(\s*"Wolverine"\s*\)|PersistMessagesWithPostgresql' --type=cs
echo
echo "== Inspect Program startup wiring =="
fd -i 'Program.cs' src tests | xargs -r rg -n -C5 'PersistMessagesWithPostgresql|ConnectionStrings|Wolverine'
echo
echo "== Inspect fixture config block for mismatch =="
rg -n -C4 'ConnectionStrings:Wolverine|ConnectionStrings__Wolverine' tests/Api/Axis.Api.Tests/Helpers/ApiTestFixture.csRepository: phuong-labs/axis
Length of output: 7006
Synchronize in-memory ConnectionStrings:Wolverine config with the dedicated test database value.
Line 88 should use _wolverineConnectionString instead of _postgres.GetConnectionString(). The environment variable on line 73 correctly points to the dedicated Wolverine test DB (axis_wolverine_test), but the in-memory config falls back to the shared DB. This inconsistency risks tests using the wrong database if configuration resolution precedence changes or if the value is read again after in-memory config is applied.
Fix
["ConnectionStrings:Wolverine"] = _postgres.GetConnectionString(),
+ ["ConnectionStrings:Wolverine"] = _wolverineConnectionString,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/Api/Axis.Api.Tests/Helpers/ApiTestFixture.cs` at line 73, The in-memory
configuration for "ConnectionStrings:Wolverine" is being set to
_postgres.GetConnectionString() causing a mismatch with the environment variable
that points to _wolverineConnectionString; update the code that seeds the
in-memory config (in ApiTestFixture where you build the test configuration /
ConfigureAppConfiguration) to use _wolverineConnectionString instead of calling
_postgres.GetConnectionString(), ensuring the in-memory config key
"ConnectionStrings:Wolverine" and the Environment.SetEnvironmentVariable call
both reference the same _wolverineConnectionString value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First implementation step toward the ADR-009 Wolverine durable inbox/outbox rollout. Configures
PersistMessagesWithPostgresql(..., "wolverine")inAxis.Api.Program, adds aConnectionStrings:Wolverineentry (same database as the modules), and auto-provisions the dedicated schema in Development + Testing viaAddResourceSetupOnStartup(). No DbContext is enlisted yet — the existing in-memorybus.PublishAsyncinAxis.Shared.Infrastructure.Persistence.UnitOfWorkstays until each module integrates via.IntegrateWithWolverine()in follow-up PRs. Also pinsNpgsql9.0.4 centrally to resolve a transitive version conflict surfaced byWolverineFx.Postgresql.Linked spec
Requirements & rules followed
wolverineschema, fully-qualified table names, dev auto-setup + prod scripted migration.PROGRESS.mdShared Kernel note flipped from "decided" to "partial — schema wired, DbContext enlistment pending"dotnet build0/0, all unit-test projects green,dotnet format --verify-no-changesgreen. Testcontainers integration tests deferred to CI (local Docker not available)docs/PROGRESS.md,docs/epics/E01-platform-foundation/features/F01-tenant-registration.mdupdated in same PR;./scripts/check-doc-drift.shgreenTODO/FIXME/ placeholder / stubSummary by CodeRabbit
New Features
Documentation
Chores
Tests