Index replaces app as controller

Author: iMattPro

event/listener.php

@@ -126,7 +126,7 @@ public function add_permission($event)
 	*/
 	public function viewonline_page($event)
 	{
-		if ($event['on_page'][1] === 'app' && strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/rules') === 0)
+		if ($event['on_page'][1] === 'index' && strrpos($event['row']['session_page'], 'index.' . $this->php_ext . '/rules') === 0)
 		{
 			$event['location'] = $this->lang->lang('BOARDRULES_VIEWONLINE');
 			$event['location_url'] = $this->controller_helper->route('phpbb_boardrules_main_controller');

tests/entity/rule_entity_message_test.php

@@ -26,9 +26,9 @@ protected function setUp(): void
 		$db = $this->db;
 
 		$request = new \phpbb_mock_request();
-		$request->overwrite('SCRIPT_NAME', '/app.php', \phpbb\request\request_interface::SERVER);
-		$request->overwrite('SCRIPT_FILENAME', 'app.php', \phpbb\request\request_interface::SERVER);
-		$request->overwrite('REQUEST_URI', '/app.php', \phpbb\request\request_interface::SERVER);
+		$request->overwrite('SCRIPT_NAME', '/index.php', \phpbb\request\request_interface::SERVER);
+		$request->overwrite('SCRIPT_FILENAME', 'index.php', \phpbb\request\request_interface::SERVER);
+		$request->overwrite('REQUEST_URI', '/index.php', \phpbb\request\request_interface::SERVER);
 
 		$user = new \phpbb_mock_user();
 		$user->optionset('viewcensors', false);

tests/event/listener_test.php

@@ -326,26 +326,26 @@ public static function viewonline_page_data()
 				'$location_url',
 				'$location',
 			),
-			// test when on_page is app and session_page is NOT for boardrules
+			// test when on_page is index and session_page is NOT for boardrules
 			array(
 				array(
-					1 => 'app',
+					1 => 'index',
 				),
 				array(
-					'session_page' => 'app.' . $phpEx . '/foobar'
+					'session_page' => 'index.' . $phpEx . '/foobar'
 				),
 				'$location_url',
 				'$location',
 				'$location_url',
 				'$location',
 			),
-			// test when on_page is app and session_page is for boardrules
+			// test when on_page is index and session_page is for boardrules
 			array(
 				array(
-					1 => 'app',
+					1 => 'index',
 				),
 				array(
-					'session_page' => 'app.' . $phpEx . '/rules'
+					'session_page' => 'index.' . $phpEx . '/rules'
 				),
 				'$location_url',
 				'$location',

tests/functional/boardrules_controller_test.php

@@ -20,7 +20,7 @@ class boardrules_controller_test extends boardrules_functional_base
 	*/
 	public function test_boardrules_page()
 	{
-		$crawler = self::request('GET', 'app.php/rules');
+		$crawler = self::request('GET', 'index.php/rules');
 		$this->assertContainsLang('BOARDRULES_HEADER', $crawler->filter('h2')->text());
 
 		self::assertEquals(1, $crawler->filter('#example-category')->count());

tests/functional/viewonline_test.php

@@ -22,7 +22,7 @@ public function test_viewonline_visit_rules()
 	{
 		// Send the admin to the Rules page
 		$this->login();
-		$crawler = self::request('GET', "app.php/rules?sid={$this->sid}");
+		$crawler = self::request('GET', "index.php/rules?sid={$this->sid}");
 		$this->assertContainsLang('BOARDRULES_HEADER', $crawler->filter('h2')->text());
 	}