Fix pcntl_rfork() / pcntl_forkx() with zend-max-execution-timers#18958
Closed
arnaud-lb wants to merge 1 commit intophp:PHP-8.3from
Closed
Fix pcntl_rfork() / pcntl_forkx() with zend-max-execution-timers#18958arnaud-lb wants to merge 1 commit intophp:PHP-8.3from
arnaud-lb wants to merge 1 commit intophp:PHP-8.3from
Conversation
Member
Author
|
Closed by aee1d7f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After calling
pcntl_rfork()orpcntl_forkx(), the child process triggers a fatal error during shutdown, in ZTS builds with--enable-zend-max-execution-timers:Here I fix this issue by calling
zend_max_execution_timer_init();in the child process, as we do inpcntl_fork():php-src/ext/pcntl/pcntl.c
Lines 299 to 300 in c7c6a79
php-src/Zend/zend_max_execution_timer.h
Lines 25 to 26 in c7c6a79
See also: #10141