Skip to content

Run LLVM 20 on ppc64#21964

Open
NattyNarwhal wants to merge 1 commit intophp:PHP-8.2from
NattyNarwhal:ppc64-llvm20
Open

Run LLVM 20 on ppc64#21964
NattyNarwhal wants to merge 1 commit intophp:PHP-8.2from
NattyNarwhal:ppc64-llvm20

Conversation

@NattyNarwhal
Copy link
Copy Markdown
Member

Already installed, be consistent with the other platforms. Applying to PHP-8.2 and merging upward since this file needs to be consistent across branches.

Already installed, be consistent with the other platforms.
@TimWolla
Copy link
Copy Markdown
Member

TimWolla commented May 6, 2026

since this file needs to be consistent across branches.

@iluuu1994 Does it actually for compiler versions? Also: I tried adding the PPC64 label and then reran the job, should it pick up the label then? It didn't, but not sure if that should work for reruns vs triggering a completely new job.

@iluuu1994
Copy link
Copy Markdown
Member

Does it actually for compiler versions?

The file should be consistent across branches, but compiler versions shouldn't be bumped for old PHP versions. So this should be done via a version check, preferably in matrix.php via config option passed to the yml file as in the Ubuntu builds.

Also: I tried adding the PPC64 label and then reran the job, should it pick up the label then? It didn't, but not sure if that should work for reruns vs triggering a completely new job.

I think this is a GitHub Actions quirk where rerunning the job re-uses the previous metadata, including the old labels. See https://github.com/php/php-src/actions/runs/25443461773/job/74650931082?pr=21964, the labels are missing in the input.

@NattyNarwhal
Copy link
Copy Markdown
Member Author

The file should be consistent across branches, but compiler versions shouldn't be bumped for old PHP versions. So this should be done via a version check, preferably in matrix.php via config option passed to the yml file as in the Ubuntu builds.

I noticed Alpine got bumped to clang-20 on PHP-8.2 too.

@iluuu1994
Copy link
Copy Markdown
Member

To be more precise: It's ok to bump compiler versions in old branches in case the version goes out of support. But it's also useful to keep it to find compatibility issues. We also don't backport all fixes for warnings, at least to security branches. So that can also be an issue. But I'm not strictly against this.

Also: I tried adding the PPC64 label and then reran the job, should it pick up the label then? It didn't, but not sure if that should work for reruns vs triggering a completely new job.

Oh and also, PPC only runs on 8.4+, so we can't test it in this PR unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants