Fix WSA protocol info cleanup in request shutdown

[EdmondDantes]

PHP_FUNCTION(socket_wsaprotocol_info_export)
{
 .....
        // allocate Request memory here
	seg_name = zend_strpprintf(0, "php_wsa_for_%u", SOCKETS_G(wsa_child_count)++);
	map = CreateFileMapping(INVALID_HANDLE_VALUE, NULL, PAGE_READWRITE, 0, sizeof(WSAPROTOCOL_INFO), ZSTR_VAL(seg_name));
	if (NULL != map) {

        // put to persistent memory array
        zend_hash_add_ptr(&(SOCKETS_G(wsa_info)), seg_name, map);

Memory allocated for the request is destroyed before the SOCKETS_G(wsa_info) array is destructed

If the socket_wsaprotocol_info_release method is not called, the application terminates with the message "zend_mm_heap corrupted"

The code proposed in this patch is not ideal, and it may be worth removing the creation of the array in persistent memory. I do not fully understand the reason why it was done this way. Nevertheless, this code works correctly.

P.S. Apparently, this bug is present in all PHP versions.

[devnexen]

Hi please target PHP-8.5 (without the last .0) thanks :)

[EdmondDantes]

Hi please target PHP-8.5 (without the last .0) thanks :)

Done

[devnexen]

How difficult would be to make test/reproducer ?

[EdmondDantes]

How difficult would be to make test/reproducer ?

Hello. Sorry I didn’t see the message earlier. I need to think about how to do this.