Allow buzz-adapter to be installed for buzz client ^0.17.2#23
Allow buzz-adapter to be installed for buzz client ^0.17.2#23MarioBlazek wants to merge 1 commit into
Conversation
|
looking at https://travis-ci.org/php-http/buzz-adapter/jobs/646883269?utm_medium=notification&utm_source=github_status there seems to be a problem with calling a non-existing method Buzz\Client\FileGetContents::setMaxRedirects - can you check what is happening there? |
|
I have checked the problem. Looks like that Buzz @dbu do you think is it worth updating buzz-adapter to support |
|
afaik @Nyholm is involved quite a bit with buzz, maybe he can say what he things would make sense? |
|
Buzz 1.0 supports HTTPlug 1 and 2. Im not sure what features 0.17 brings over 0.15. ie, why would you update? |
Im not sure. It is just a minor BC breaks from what I can recall. It may be possible (with just a few lines of code) to add support for 0.17 too. OR, one can release a new major version of this Buzz adapter to only support 0.15.
Yes, that is where I would spend my time. |
| License | MIT
What's in this PR?
This PR enables buzz-adapter to be installed for Buzz client
^0.17.2.Why?
Some of us are still stuck with Buzz
0.17.2and we are not able to upgrade to~1.0. Due to semantic versioning buzz-adapter version constraint^0.15.2won't allow Buzz0.17.