Skip to content

feat: implement issue #227 — Compliance: secret_scanning_non_provider_patterns - #236

Closed
don-petry wants to merge 8 commits into
mainfrom
dev-lead/issue-227-20260530-1356
Closed

don-petry wants to merge 8 commits into
mainfrom
dev-lead/issue-227-20260530-1356

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Closes #227

Implemented by dev-lead agent. Please review.

Copilot AI review requested due to automatic review settings May 30, 2026 13:59
@don-petry
don-petry requested a review from a team as a code owner May 30, 2026 13:59
@coderabbitai

coderabbitai Bot commented May 30, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 55 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8f01e6d-dac2-4799-bd91-bac510d71fb9

📥 Commits

Reviewing files that changed from the base of the PR and between 5185d53 and 2cb1810.

📒 Files selected for processing (1)
  • .github/workflows/compliance-settings.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-lead/issue-227-20260530-1356

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a duplicate entry for .dev-lead/ to the .gitignore file. The review feedback correctly points out that this directory is already ignored multiple times in the file, making the new entry redundant.

Comment thread .gitignore Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an automated GitHub Actions workflow to keep the repo compliant with org push-protection settings (issue #227), specifically enabling secret_scanning_non_provider_patterns.

Changes:

  • Adds a new workflow that runs on pushes to main (and manually) to enable secret_scanning_non_provider_patterns via an existing repo script.
  • Updates .gitignore to ignore .dev-lead/ (but currently introduces another duplicate entry).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
.gitignore Adds another .dev-lead/ ignore entry (currently results in many duplicates).
.github/workflows/compliance-settings.yml New workflow to enable secret_scanning_non_provider_patterns using a PAT-backed gh api call.

Comment thread .github/workflows/compliance-settings.yml Outdated
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) May 30, 2026 14:12
@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (applied)

Changes committed and pushed.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@sonarqubecloud

sonarqubecloud Bot commented Jun 1, 2026

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — fix-bot-comment (no-changes)

Agent reasoning
Issues addressed: 2
- Duplicate `.dev-lead/` entry in .gitignore: removed the extra line; working tree is now clean [thread resolved — gemini-code-assist]
- GH_TOKEN scoped at job level: already fixed (token is inside the step's `env` block, not the job block); outdated thread resolved [thread resolved — copilot-pull-request-reviewer]
Files changed: .gitignore (duplicate entry removed)
Skipped (informational): 0
```
**Notes:**
- The `.gitignore` had an uncommitted working-tree duplicate of `.dev-lead/` — removed it, restoring the file to match HEAD (working tree is now clean).
- The `compliance-settings.yml` `GH_TOKEN` concern was already addressed: the token is scoped only to the `Enable secret_scanning_non_provider_patterns` step's `env:` block, not at the job level.
- No SonarQube hotspot patterns (`curl | bash`, hardcoded credentials, HTTP downloads) were found in the PR's changed files.

@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:17

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: secret_scanning_non_provider_patterns

3 participants