Skip to content

chore(compliance): align dependabot.yml with frontend standard template - #106

Closed
don-petry wants to merge 24 commits into
mainfrom
claude/issue-91-20260414-1327
Closed

don-petry wants to merge 24 commits into
mainfrom
claude/issue-91-20260414-1327

Conversation

@don-petry

@don-petry don-petry commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds explanatory comments to .github/dependabot.yml to match the org standard template (standards/dependabot/frontend.yml)
  • Documents the intentional open-pull-requests-limit: 0 for npm (Dependabot security updates bypass this limit; only version updates are suppressed)

Compliance context

The allow_auto_merge repository setting is already enabled (true) and dependabot-automerge.yml is already in place and matches the org template. This PR closes the compliance finding by confirming and documenting the full Dependabot auto-merge setup.

Closes #91


Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Refined Dependabot configuration to separately manage npm and GitHub Actions dependency updates with optimized scheduling and pull request limits.

Add comments from petry-projects/.github/standards/dependabot/frontend.yml
to document the intentional open-pull-requests-limit: 0 for npm (security
updates bypass the limit; version updates are suppressed).

The allow_auto_merge repository setting is already enabled (true) and
dependabot-automerge.yml is already in place.

Closes #91

Co-authored-by: don-petry <don-petry@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 14, 2026 13:31
@coderabbitai

coderabbitai Bot commented Apr 14, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The .github/dependabot.yml configuration now explicitly defines separate update rules for npm and github-actions ecosystems. The npm ecosystem is configured to suppress non-security PRs via open-pull-requests-limit: 0, while github-actions allows version update PRs with open-pull-requests-limit: 10. Both ecosystems receive security and dependencies labels.

Changes

Dependabot Ecosystem Configuration

Layer / File(s) Summary
Ecosystem Update Policies
.github/dependabot.yml
npm ecosystem configured for security-only updates (open-pull-requests-limit: 0) with security and dependencies labels; github-actions ecosystem configured for version updates (open-pull-requests-limit: 10) with same labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • petry-projects/TalkTerm#32: Makes identical changes to .github/dependabot.yml, adding npm ecosystem configuration with open-pull-requests-limit: 0 and security/dependencies labels.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR claims to close issue #91 but only adds comments to dependabot.yml without actually enabling the allow_auto_merge repository setting that the issue requires. Enable the allow_auto_merge repository setting (set to true) as required by issue #91, or clarify if this was already corrected separately.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: aligning dependabot.yml with the frontend standard template by adding explanatory comments.
Out of Scope Changes check ✅ Passed The changes are limited to adding comments to dependabot.yml configuration, which aligns with the stated objective of matching the org standard template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-91-20260414-1327

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates .github/dependabot.yml to align with the org’s frontend Dependabot standard template by adding clarifying comments about the intended update behavior (notably open-pull-requests-limit: 0 for npm version updates while still allowing security updates).

Changes:

  • Added header/template comments explaining the config intent and how npm updates are constrained.
  • Added inline comments documenting the rationale for npm (security-only) and GitHub Actions (version updates) entries.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@don-petry

don-petry commented Apr 16, 2026 •

Copy link
Copy Markdown
Contributor Author
Outdated review (superseded by re-review at 5ab0807cb8351ed914c7f85672e8aeaa1d1e0f7d) — click to expand.

Automated review — APPROVED

Risk: LOW
Reviewed commit: af806fe040186f2a9d9ae37d0bf6b902f8f3067b
Cascade: triage → deep (see triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6 for models)

Summary

This PR adds 7 comment lines to .github/dependabot.yml for documentation alignment with the org standard template — no functional changes at all. All CI checks pass cleanly (SonarCloud: 0 issues/0 hotspots, CodeQL: clean, AgentShield: green). The triage escalation was due to an internal triage failure, not a genuine risk signal in this PR.

Findings

Info

  • .github/dependabot.yml:2 — The comment # Copy to .github/dependabot.yml and adjust directory paths as needed is template boilerplate that reads as instructions inside the file it's already deployed in. Consider rewording to # Based on petry-projects/.github/standards/dependabot/frontend.yml or similar.
  • (general) — Issue Compliance: allow_auto_merge #91 is a compliance finding about the allow_auto_merge repository setting being null/false, not about dependabot.yml comments. This PR adds comments but does not change the repository setting. If the compliance audit re-runs, it may not close the finding unless the repository setting was already corrected separately (as the PR body asserts).

CI status

All CI checks pass cleanly (SonarCloud: 0 issues/0 hotspots, CodeQL: clean, AgentShield: green).


Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@don-petry
don-petry enabled auto-merge (squash) April 16, 2026 14:25

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@petry-projects-pr-review-agent petry-projects-pr-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@github-actions
github-actions Bot requested a review from a team as a code owner May 4, 2026 20:39

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by the don-petry PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: gpt-5.4 → audit: opus 4.6). Reply with @don-petry if you need a human.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/dependabot.yml:
- Line 2: The boilerplate line "Copy to .github/dependabot.yml and adjust
directory paths as needed" implies this is a template; update that single
comment to make clear this is the active/deployed dependabot config and, if
helpful, reference its source or repo template (e.g., "This is the active
Dependabot configuration — adapted from [source/template] — update directory
paths here as needed"), replacing the existing sentence so future maintainers
aren't misled; edit the comment in the top of .github/dependabot.yml
accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 599ff2f7-7917-494b-9ccc-ae53b572b29d

📥 Commits

Reviewing files that changed from the base of the PR and between 3d6531e and 4b545b2.

📒 Files selected for processing (1)
  • .github/dependabot.yml

Comment thread .github/dependabot.yml
@@ -1,5 +1,11 @@
# Dependabot configuration for frontend (npm) repositories
# Copy to .github/dependabot.yml and adjust directory paths as needed

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Reword the template boilerplate to avoid confusion.

The comment "Copy to .github/dependabot.yml and adjust directory paths as needed" reads as if this is still a template file, but this IS the deployed .github/dependabot.yml. This could confuse future maintainers.

Consider rewording to reference the source, for example:

-# Copy to .github/dependabot.yml and adjust directory paths as needed
+# Based on petry-projects/.github/standards/dependabot/frontend.yml
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# Copy to .github/dependabot.yml and adjust directory paths as needed
# Based on petry-projects/.github/standards/dependabot/frontend.yml
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/dependabot.yml at line 2, The boilerplate line "Copy to
.github/dependabot.yml and adjust directory paths as needed" implies this is a
template; update that single comment to make clear this is the active/deployed
dependabot config and, if helpful, reference its source or repo template (e.g.,
"This is the active Dependabot configuration — adapted from [source/template] —
update directory paths here as needed"), replacing the existing sentence so
future maintainers aren't misled; edit the comment in the top of
.github/dependabot.yml accordingly.

@don-petry don-petry closed this May 11, 2026
auto-merge was automatically disabled May 11, 2026 21:40

Pull request was closed

@don-petry don-petry reopened this May 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

donpetry-bot
donpetry-bot previously approved these changes May 14, 2026

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: b3ae115a967f444ab952dbdc23cf5384f0387e93
Cascade: triage → deep (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7)

Summary

This PR adds 7 comment lines to .github/dependabot.yml — purely documentation, zero functional changes. The recurring triage escalation signal (concern that allow_auto_merge was not enabled) is now resolved: issue #91 is CLOSED, confirming the repository setting was already applied. All CI gates pass cleanly (CodeQL success, SonarCloud 0 issues/hotspots, CodeRabbit SUCCESS).

Findings

  • info: Issue #91 is now CLOSED. The compliance audit finding for allow_auto_merge has been resolved (confirmed true by Claude agent in issue and by the issue's closed state). The CodeRabbit pre-merge warning about 'only adds comments without enabling the setting' is stale — the setting was applied separately (PR #119 re-applied it on 2026-04-20).
  • info: Line 2 reads 'Copy to .github/dependabot.yml and adjust directory paths as needed' — template boilerplate that implies this is a source template, not the deployed config. CodeRabbit also flagged this. Consider rewording to 'Adapted from petry-projects/.github/standards/dependabot/frontend.yml' or similar. Minor cosmetic issue, not a blocker.
  • info: mergeStateStatus is BLOCKED despite clean CI and multiple bot approvals (reviewDecision is empty). This is likely a branch protection rule requiring a human/org-member review, not a code quality issue.

Reviewed by the PR-review cascade (triage: haiku 4.5 → deep: sonnet 4.6 + duck: o4-mini → audit: opus 4.7). Reply if you need a human review.

@donpetry-bot
donpetry-bot enabled auto-merge (squash) May 14, 2026 10:29

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: 6adb41274e560153f5a296976a51996b67e349c9
Review mode: triage-approved (single reviewer)

Summary

Triage tier already cleared this as low-risk; this is a brief confirmation pass. The PR adds 7 comment lines to .github/dependabot.yml (documentation alignment with the org standard template) with zero functional changes. All CI gates pass, and the linked compliance finding is fully resolved.

Linked issue analysis

Issue #91 — "Compliance: allow_auto_merge" — is CLOSED (closed 2026-04-26). The repository-level allow_auto_merge setting was enabled separately, and this PR documents the intentional open-pull-requests-limit: 0 for npm in alignment with the org standard template. The CodeRabbit pre-merge warning about "only adds comments" is stale.

Findings

No blocking issues. Cosmetic-only nits previously noted (e.g., the line-2 "Copy to .github/dependabot.yml and adjust directory paths as needed" comment reads like template boilerplate now that this is the deployed config) remain non-blocking.

Since the prior review at b3ae115a967f444ab952dbdc23cf5384f0387e93, the only new commits are two main-merges touching .github/workflows/claude.yml and .github/workflows/dev-lead.yml — unrelated to this PR's scope.

CI status

All green: CodeQL (actions, python) SUCCESS, SonarCloud Quality Gate PASSED (0 new issues, 0 hotspots), CodeRabbit SUCCESS. mergeStateStatus: BLOCKED reflects branch protection awaiting a qualifying review, not a CI failure.


Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review.

@donpetry-bot
donpetry-bot dismissed their stale review May 17, 2026 01:45

Superseded by automated re-review at 6adb412.

@don-petry

Copy link
Copy Markdown
Contributor Author

@dev-lead - please fix this PR

@sonarqubecloud

Copy link
Copy Markdown

@donpetry-bot

Copy link
Copy Markdown
Contributor

Automated review — human attention needed

This PR has been through 3 automated review cycles (cap: 3) without converging on an approval-and-merge state. Further automated review has been paused to avoid infinite loops.

Please take a look manually, or close this PR if it's no longer needed. Once a human review resolves the situation, remove the needs-human-review label and the cascade can be re-engaged on the next push.

Posted by the donpetry-bot PR-review cascade.

@donpetry-bot donpetry-bot added the needs-human-review Requires human review label May 30, 2026
@donpetry-bot
donpetry-bot requested a review from a team May 30, 2026 20:37
@don-petry

Copy link
Copy Markdown
Contributor Author

Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead.

@don-petry don-petry closed this Jun 2, 2026
auto-merge was automatically disabled June 2, 2026 12:22

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-human-review Requires human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compliance: allow_auto_merge

4 participants