From 2a3b16604ff4de7a8478fce14ed28b4cd2edd3ea Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Tue, 11 Aug 2026 18:57:38 +0000 Subject: [PATCH 1/2] =?UTF-8?q?feat:=20implement=20issue=20#956=20?= =?UTF-8?q?=E2=80=94=20Compliance:=20ruleset-drift-pr-quality-dismiss=5Fst?= =?UTF-8?q?ale=5Freviews=5Fon=5Fpush?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../scripts/compliance-audit/ruleset-contents-drift.bats | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/test/scripts/compliance-audit/ruleset-contents-drift.bats b/test/scripts/compliance-audit/ruleset-contents-drift.bats index b73487f8..b70668e6 100644 --- a/test/scripts/compliance-audit/ruleset-contents-drift.bats +++ b/test/scripts/compliance-audit/ruleset-contents-drift.bats @@ -126,6 +126,15 @@ MOCK [[ "$output" == *"ruleset-drift-pr-quality-require_code_owner_review"* ]] } +@test "disabled dismiss_stale_reviews_on_push → finding naming expected/actual" { + drifted="$(echo "$PRQ_PARAMS" | jq -c '.dismiss_stale_reviews_on_push=false')" + run _run_contents "$drifted" "$CQ_PARAMS" + [ "$status" -eq 0 ] + [[ "$output" == *"ruleset-drift-pr-quality-dismiss_stale_reviews_on_push"* ]] + [[ "$output" == *"dismiss_stale_reviews_on_push"* ]] + [[ "$output" == *"error"* ]] +} + # --------------------------------------------------------------------------- # allowed_merge_methods widened beyond squash-only → drift # --------------------------------------------------------------------------- From d5c5f7037673519d25a38c34b0b895b03a3a7efb Mon Sep 17 00:00:00 2001 From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com> Date: Tue, 11 Aug 2026 19:04:06 +0000 Subject: [PATCH 2/2] fix(reviews): address review comments [skip ci-relay] --- test/scripts/compliance-audit/ruleset-contents-drift.bats | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/scripts/compliance-audit/ruleset-contents-drift.bats b/test/scripts/compliance-audit/ruleset-contents-drift.bats index b70668e6..2867f9ae 100644 --- a/test/scripts/compliance-audit/ruleset-contents-drift.bats +++ b/test/scripts/compliance-audit/ruleset-contents-drift.bats @@ -133,6 +133,8 @@ MOCK [[ "$output" == *"ruleset-drift-pr-quality-dismiss_stale_reviews_on_push"* ]] [[ "$output" == *"dismiss_stale_reviews_on_push"* ]] [[ "$output" == *"error"* ]] + [[ "$output" == *'expected `true`'* ]] + [[ "$output" == *'actual `false`'* ]] } # ---------------------------------------------------------------------------