Repository navigation
feat: implement issue #1277 — Standards sweep reports a drifted initiative-driver.yml as compliant — the template gained a uses: step, so the stub is no longer compared verbatim (repo-template still on ref: v1) - #1278
Conversation
…ative-driver.yml as compliant — the template gained a `uses:` step, so the stub is no longer compared verbatim (repo-template still on `ref: v1`)
don-petry
added
the
auto-rebase:ready
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 24 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a shared library stub-verbatim.sh to align verbatim-managed stub detection and full-content comparison between the compliance audit and deploy sweep scripts, resolving issues where drifted stubs were incorrectly flagged as compliant. Additionally, it secures initiative-driver.yml against template injection by passing github.repository via an environment variable. The review feedback suggests improving error handling in compliance-audit.sh by propagating gh_api failures rather than silently ignoring them, and refactoring the BATS tests to avoid generic negation (! cmd) when asserting command failures.
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
CodeAnt PR Risk: Low Risk
Assessed commit: |
…status in bats Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Dev-Lead — review-changes (applied)Changes committed and pushed. Requested items addressed:
|
…ables by workflow path Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No description provided. |
Dev-Lead — fix-reviews (applied)Changes committed and pushed. Requested items addressed:
|
don-petry
left a comment
don-petry
left a comment
There was a problem hiding this comment.
Maintainer request: clear the SonarQube code smells this PR introduced. The quality gate passes, but SonarQube reports 11 new issues on the PR. Ten are in code this PR added; the list and the required handling are inline.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Dev-Lead — fix-reviews (applied)Changes committed and pushed. Requested items addressed:
|
don-petry
left a comment
don-petry
left a comment
There was a problem hiding this comment.
Maintainer request: clear the last SonarQube issue on this PR (S1192, the ci-workflows literal). This reverses my earlier "leave it alone" on that one item.
… duplication Define CI_WORKFLOWS_CATEGORY constant and use it in all add_finding() calls (22 occurrences) instead of repeating the hardcoded 'ci-workflows' string. Reduces duplication while keeping contextual literals in case patterns, metadata, and category loops where they serve as data values. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
Fixed S1192 duplicate string literal in scripts/compliance-audit.sh: extracted 'ci-workflows' to a CI_WORKFLOWS_CATEGORY constant and replaced all 22 occurrences in add_finding() calls. Reduces duplication while maintaining contextual literals in case patterns and category loops. |
|
No description provided. |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
|
|
No description provided. |
|
This is a rate-limit notice from CodeRabbit indicating the free OSS review quota has been exhausted. The comment contains no code findings or actionable issues — it is purely an operational notice that no code change is required to address. |
Dev-Lead — fix-bot-comment (no-changes)Agent reasoning |
|
No description provided. |
2 participants
Problem
Standards sweep reports a drifted initiative-driver.yml as compliant — the template gained a
uses:step, so the stub is no longer compared verbatim (repo-template still onref: v1)From the issue:
scripts/deploy-standard-workflows.shreports a driftedinitiative-driver.ymlstub asalready compliant, so the sweep never re-syncs it.Risk
Medium — changes GitHub Actions workflow behavior, which is exercised only post-merge; verify via the affected workflow runs.
Test plan
Tests added/updated:
test/scripts/deploy-standard-workflows/verbatim-managed-stub.bats,test/workflows/initiative-driver/gate-tooling.bats. Verification:bash scripts/dev-lead-lint.sh(shellcheck --severity=warning) ran pre-commit; the bats suite runs in CI.Rollback
Revert this PR. No non-revertible side effects (no tags, migrations, or external state).
Monitoring
Watch the affected workflow run(s) in the Actions tab and this PR's Lint check for regressions.
Closes #1277