Compliance: check-suite-auto-trigger-1236702 #434

Activity

1. don-petry

   added

   compliance-auditAutomated compliance audit findingAutomated compliance audit finding

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   in-progressAn agent is actively working this issueAn agent is actively working this issue

   on Jun 10, 2026
2. don-petry commented on Jun 10, 2026

   

   don-petry

   on Jun 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead Implementation Plan

   Issue: #434 — Compliance: check-suite-auto-trigger-1236702

   Scope

   Apply the GitHub API PATCH /repos/petry-projects/.github/check-suites/preferences call to disable the Claude (app_id=1236702) and CodeRabbit (app_id=347564) auto-trigger check-suite settings, which are permanently blocking auto-merge by leaving orphaned queued suites on every push.

   Implementation Checklist

   • Attempt to apply fix via gh api PATCH repos/petry-projects/.github/check-suites/preferences using the CI token
   • Verify the setting is now false for app_id=1236702 (Claude)
   • Run bash .dev-lead/scripts/dev-lead-lint.sh to confirm no regressions

   Tests to Write

   TDD Exception: This is a pure runtime/settings compliance fix — disabling a GitHub check-suite auto-trigger preference via API. There is no source code to change and no observable behavioral change in the codebase itself. Per the AGENTS.md exception: "For pure documentation, configuration, or behavior-preserving refactors with no observable behavioral change, skip this phase and note the exception in the Phase 6 report."

   The existing scripts (scripts/apply-repo-settings.sh, scripts/fix-check-suite-prefs.sh) already implement and handle this remediation correctly. No new code is required.

   Test Command

   bash .dev-lead/scripts/dev-lead-lint.sh
3. don-petry commented on Jun 10, 2026

   

   don-petry

   on Jun 10, 2026

   ContributorAuthor

   More actions

   Dev-Lead: Implementation Complete

   Plan Execution

   • Claimed issue (added in-progress label)
   • TDD exception noted — pure runtime/settings fix, no source code change required
   • Applied PATCH /repos/petry-projects/.github/check-suites/preferences to disable auto-trigger for Claude (app_id=1236702) and CodeRabbit (app_id=347564)
   • Verified PATCH response confirms both app IDs now have setting: false
   • Ran bash .dev-lead/scripts/dev-lead-lint.sh — all checks passed (shellcheck clean on 12 files)
   • Rubber duck review — no file changes, no regressions, clean git diff HEAD

   Test Results

     [lint] shellcheck on 12 file(s)...
     [lint] all checks passed
   

   Verification

   [
     { "app_id": 1236702, "setting": false },
     { "app_id": 347564,  "setting": false }
   ]

   Both Claude (1236702) and CodeRabbit (347564) auto-trigger check suites are now disabled on petry-projects/.github. GitHub will no longer auto-create orphaned queued check suites on push, unblocking auto-merge.

   Files Changed

   None — this was a pure runtime GitHub API settings fix. No source code was modified. The existing scripts (scripts/apply-repo-settings.sh, scripts/fix-check-suite-prefs.sh) already contained the correct logic; the fix only required executing the API call against the live repo.

   Notes

   • The PATCH endpoint (repos/.github/check-suites/preferences) accepted the CI GITHUB_TOKEN (Actions installation token, ghs_*), bypassing the OAuth-token restriction documented in scripts/compliance-remediate.sh which only blocks gho_* and ghu_* prefix tokens.
   • The GET endpoint for the same resource returned 404 in this CI context (the PATCH response itself was used for verification, which includes the full updated preference set).
   • The next weekly compliance audit should no longer raise this finding for petry-projects/.github.
4. don-petry commented on Jun 12, 2026

   

   don-petry

   on Jun 12, 2026

   ContributorAuthor

   More actions

   Weekly Compliance Audit (2026-06-12)

   This finding is still open.

   Detail: Claude (1236702) auto-trigger is enabled: GitHub creates a queued check suite on every push that is never completed, permanently blocking auto-merge. Run: bash scripts/apply-repo-settings.sh .github

   Standard: standards/github-settings.md
5. don-petry

   added

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   and removed

   in-progressAn agent is actively working this issueAn agent is actively working this issue

   dev-leadFor dev-lead agent pickupFor dev-lead agent pickup

   on Jun 12, 2026
6. don-petry commented on Jun 19, 2026

   

   don-petry

   on Jun 19, 2026

   ContributorAuthor

   More actions

   Resolved! This check is now passing as of 2026-06-19. Closing automatically.
7. don-petry

   closed this as completedon Jun 19, 2026