💾 Feat/25 Add Iobio components#207
Conversation
…o feat/25-add-iobio-components
demariadaniel
changed the title
| const dom = new JSDOM('', { url: 'http://localhost/' }); | ||
|
|
||
| // @ts-ignore | ||
| global.window = dom.window; |
There was a problem hiding this comment.
Obviously ts-ignore is not ideal, I'll take a second look at this
There was a problem hiding this comment.
was this JSDOM necessary for the SSR issues? if so, perhaps it can be removed now
There was a problem hiding this comment.
No I've tested this several times and it causes errors when removed. Might be worth a deep dive, there may be a better Next-centric approach.
There was a problem hiding this comment.
To be clear, yes JSDOM is solving part of the web components / SSR issue, plus the client side async import.
| <h2>Bam.iobio</h2> | ||
| <> | ||
| <IobioDataBroker | ||
| alignmentUrl={'https://s3.amazonaws.com/iobio/NA12878/NA12878.autsome.bam'} |
There was a problem hiding this comment.
This value should be abstracted as an env var.
There was a problem hiding this comment.
Yes - this is a specific file URL, so it will either live in a TableContext or in the URL query eventually
It's hard coded because implementation is still TBD
| global.document = global.window.document; | ||
| global.Element = global.window.Element; | ||
| global.localStorage = global.window.localStorage; | ||
| global.navigator = global.window.navigator; |
There was a problem hiding this comment.
These global.* values are all undefined when the iobio script is loaded on the server
| > | ||
| <TableContextProvider> | ||
| <h2>Bam.iobio</h2> | ||
| <> |
|
|
||
| return useMemo( | ||
| () => ( | ||
| <> |
There was a problem hiding this comment.
Don't need this empty tag, there is an <article> tag around all the content here.
3 participants
https://app.zenhub.com/workspaces/overture-stack-5d2e058ff67cc800011fee6b/issues/gh/overture-stack/iobio-components/25