-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[OSDOCS#17012]: Bare metal ipi CQA workflow 1 #117340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,13 +85,10 @@ storage: | |
| # Serve time even if not synchronized to a time source. | ||
| local stratum 3 orphan | ||
| ---- | ||
| + | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lol I am confused by how these description lists still indent correctly and don't restart the number order without the first +, but I guess if it works it works |
||
| where: | ||
| + | ||
| -- | ||
|
|
||
| `<cluster-name>`:: Specifies the name of the cluster. | ||
| `<domain>`:: Specifies the fully qualified domain name. | ||
| -- | ||
|
|
||
| . Use Butane to generate a `MachineConfig` object file, `99-master-chrony-conf-override.yaml`, containing the configuration to be delivered to the control plane nodes: | ||
| + | ||
|
|
@@ -135,13 +132,10 @@ storage: | |
| logchange 0.5 | ||
| logdir /var/log/chrony | ||
| ---- | ||
| + | ||
| where: | ||
| + | ||
| -- | ||
|
|
||
| `<cluster-name>`:: Specifies the name of the cluster. | ||
| `<domain>`:: Specifies the fully qualified domain name. | ||
| -- | ||
|
|
||
| . Use Butane to generate a `MachineConfig` object file, `99-worker-chrony-conf-override.yaml`, containing the configuration to be delivered to the worker nodes: | ||
| + | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ | |
| [id="ipi-install-creating-a-disconnected-registry_{context}"] | ||
| = Creating a disconnected registry | ||
|
|
||
| [] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotta fill this one out 😅 |
||
| In some cases, you might want to install an {product-title} cluster using a local copy of the installation registry. This could be for enhancing network efficiency because the cluster nodes are on a network that does not have access to the internet. | ||
|
|
||
| A local, or mirrored, copy of the registry requires the following: | ||
|
|
@@ -17,5 +18,6 @@ A local, or mirrored, copy of the registry requires the following: | |
| [NOTE] | ||
| ==== | ||
| Creating a disconnected registry on a registry node is optional. If you need to create a disconnected registry on a registry node, you must complete all of the following sub-sections. | ||
| * Creating a disconnected registry on a registry node is optional. If you need to create a disconnected registry on a registry node, you must complete all of the following sub-sections. | ||
| * If you have already prepared a mirror registry for a disconnected installation by mirroring images, you can skip directly to "Modify the install-config.yaml file to use the disconnected registry" section. For more information about preparing a mirror registry for a disconnected installation by mirroring images see, "Mirroring images for a disconnected installation". | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah this is a smart way to deal with that "prereqs" section that didn't really seem to be written like a prereqs section |
||
| ==== | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything on this assembly that talks about different install methods (which makes sense - by the time you're on a page in the bare metal IPI install section, you've already decided on this method). I would suggest focusing on the environment setup only:
(also a nit here that "set up" is two words as a verb, and "setup" is only used as a noun, per the ISG)