Skip to content

Commit 0d9868a

Browse files
update client config in test_estimation_procedure
1 parent 5207d22 commit 0d9868a

1 file changed

Lines changed: 23 additions & 37 deletions

File tree

tests/test_api/test_estimation_procedures.py renamed to tests/test_api/test_estimation_procedure.py

Lines changed: 23 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
# License: BSD 3-Clause
22
from __future__ import annotations
33

4-
import pytest
5-
from openml._api.config import settings
6-
7-
from openml._api.resources.estimation_procedures import EstimationProceduresV1, EstimationProceduresV2
4+
import pytest
5+
from openml._api.resources.estimation_procedure import EstimationProcedureV1API, EstimationProcedureV2API
86
from openml.testing import TestAPIBase
97
from openml._api.resources.base.fallback import FallbackProxy
108

@@ -16,15 +14,8 @@ class TestEstimationProceduresV1(TestAPIBase):
1614

1715
def setUp(self) -> None:
1816
super().setUp()
19-
self.client = self._get_http_client(
20-
server=settings.api.v1.server,
21-
base_url=settings.api.v1.base_url,
22-
api_key=settings.api.v1.api_key,
23-
timeout=settings.api.v1.timeout,
24-
retries=settings.connection.retries,
25-
retry_policy=settings.connection.retry_policy,
26-
)
27-
self.resource = EstimationProceduresV1(self.client)
17+
self.client = self.http_client
18+
self.resource = EstimationProcedureV1API(self.client)
2819

2920
@pytest.mark.uses_test_server()
3021
def test_list(self):
@@ -56,14 +47,15 @@ class TestEstimationProceduresV2(TestAPIBase):
5647
def setUp(self) -> None:
5748
super().setUp()
5849
self.client = self._get_http_client(
59-
server=settings.api.v2.server,
60-
base_url=settings.api.v2.base_url,
61-
api_key=settings.api.v2.api_key,
62-
timeout=settings.api.v2.timeout,
63-
retries=settings.connection.retries,
64-
retry_policy=settings.connection.retry_policy,
50+
server="http://localhost:8001/",
51+
base_url="",
52+
api_key="",
53+
timeout_seconds=self.timeout_seconds,
54+
retries=self.retries,
55+
retry_policy=self.retry_policy,
56+
cache=self.cache,
6557
)
66-
self.resource = EstimationProceduresV2(self.client)
58+
self.resource = EstimationProcedureV2API(self.client)
6759

6860
@pytest.mark.uses_test_server()
6961
def test_list(self):
@@ -77,31 +69,25 @@ def test_list(self):
7769
class TestEstimationProceduresCombined(TestAPIBase):
7870
def setUp(self):
7971
super().setUp()
80-
self.v1_client = self._get_http_client(
81-
server=settings.api.v1.server,
82-
base_url=settings.api.v1.base_url,
83-
api_key=settings.api.v1.api_key,
84-
timeout=settings.api.v1.timeout,
85-
retries=settings.connection.retries,
86-
retry_policy=settings.connection.retry_policy,
87-
)
72+
self.v1_client = self.http_client
8873
self.v2_client = self._get_http_client(
89-
server=settings.api.v2.server,
90-
base_url=settings.api.v2.base_url,
91-
api_key=settings.api.v2.api_key,
92-
timeout=settings.api.v2.timeout,
93-
retries=settings.connection.retries,
94-
retry_policy=settings.connection.retry_policy,
74+
server="http://localhost:8001/",
75+
base_url="",
76+
api_key="",
77+
timeout_seconds=self.timeout_seconds,
78+
retries=self.retries,
79+
retry_policy=self.retry_policy,
80+
cache=self.cache,
9581
)
96-
self.resource_v1 = EstimationProceduresV1(self.v1_client)
97-
self.resource_v2 = EstimationProceduresV2(self.v2_client)
82+
self.resource_v1 = EstimationProcedureV1API(self.v1_client)
83+
self.resource_v2 = EstimationProcedureV2API(self.v2_client)
9884
self.resource_fallback = FallbackProxy(self.resource_v2, self.resource_v1)
9985

10086
@pytest.mark.uses_test_server()
10187
def test_list_matches(self):
10288
output_v1 = self.resource_v1.list()
10389
output_v2 = self.resource_v2.list()
104-
# output_v1 matches output_v2
90+
10591
assert isinstance(output_v1, list)
10692
assert isinstance(output_v2, list)
10793
assert output_v1 == output_v2

0 commit comments

Comments
 (0)