feat: integration tests for nodejs generator - #140
Merged
Conversation
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Signed-off-by: Adityasinghvats <131326798+Adityasinghvats@users.noreply.github.com>
Contributor
Author
|
Hey once again sorry for any inconvenience, I was not able to get rid of signoff comments from history , so I cherry picked commits and created a new branch and a new PR
|
beeme1mr
approved these changes
Jun 13, 2025
beeme1mr
left a comment
beeme1mr
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! Sorry about the DCO issue.. I know it's a pain.
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #117
Notes
Follow-up Tasks
Object flagmentioned here Basic support for object flags #101 in generators and update test accordingly.How to test