feat: add java generator - #107
Merged
Merged
Conversation
advitiya0201
force-pushed
the
feat/java-gen
branch
from
May 4, 2025 05:06
52eca86 to
fcdf687
Compare
Contributor
Author
|
Hi @beeme1mr, waiting for any comments from your side |
Member
|
Hey @advitiya0201 I'll review this tomorrow. |
beeme1mr
approved these changes
May 5, 2025
beeme1mr
left a comment
beeme1mr
left a comment
Member
There was a problem hiding this comment.
Looks a great start. Please just add some docs to the details method and we can get this in. Thanks!
Member
|
I will review this tomorrow! Thanks @advitiya0201 |
toddbaert
self-requested a review
May 5, 2025 18:43
toddbaert
reviewed
May 6, 2025
mogsie
reviewed
May 7, 2025
Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
…va.md Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
advitiya0201
force-pushed
the
feat/java-gen
branch
from
May 7, 2025 13:46
34c7ed0 to
e98d3ee
Compare
Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
…plementation Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
Signed-off-by: advitiya0201 <f20210979@pilani.bits-pilani.ac.in>
advitiya0201
force-pushed
the
feat/java-gen
branch
from
May 7, 2025 20:19
6ddb94f to
4671abf
Compare
Member
|
I'll give folks until Monday to finish their reviews. |
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Contributes to #102
Notes
Development process was pretty smooth, kudos to a well-maintained repo structure
How to test
go build./cli generate java --manifest=sample/sample_manifest.json --package-name=com.exmaple.myRepo