Skip to content

fix(devtools): reference optimizeDeps in reference to @nuxt/devtools#1001

Open
danielroe wants to merge 1 commit into
mainfrom
fix/nested-optimize-deps
Open

fix(devtools): reference optimizeDeps in reference to @nuxt/devtools#1001
danielroe wants to merge 1 commit into
mainfrom
fix/nested-optimize-deps

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented May 23, 2026

🔗 Linked issue

#980
#981

📚 Description

trying this out on the nuxt main branch, we got some warnings:

Unresolvable optimizeDeps.include entries:
  @vue/devtools-kit
  @vue/devtools-core

that's because these aren't direct dependencies of users' projects and won't be resolvable with pnpm, so I switch to using the nested path (nuxt > @nuxt/devtools > *)

another alternative might simply be to fully resolve the paths so we don't care about the dependency chain - wdyt?

@danielroe danielroe requested review from antfu and huang-julien May 23, 2026 12:19
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 23, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 423884ee-c93e-428a-8036-e64e6fe00082

📥 Commits

Reviewing files that changed from the base of the PR and between 911faed and ab8103e.

📒 Files selected for processing (1)
  • packages/devtools/src/module-main.ts

📝 Walkthrough

Walkthrough

This PR updates the Vite build optimization configuration in the Nuxt DevTools module. The optimizeDeps.include array in enableModule is modified to explicitly include Nuxt-scoped dependency specifiers for six DevTools-related packages: Vue DevTools kit and core, Vite DevTools client components, error-stack-parser-es, and the vue-tracer client overlay. This ensures these dependencies are properly optimized during the Vite build process.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating optimizeDeps references to use nested paths through @nuxt/devtools to resolve dependency chain issues.
Description check ✅ Passed The description is directly related to the changeset, explaining the problem (unresolvable optimizeDeps entries), the root cause, and the solution implemented in the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nested-optimize-deps

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/devtools/src/module-main.ts

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant