Try locking the mutex on delete, just in case process_dns_layer is running while the bucket is aged out

fformica · fformica · commit 9e5d8871b822 · 2025-08-26T15:06:30.000+01:00
diff --git a/src/handlers/dns/v1/DnsStreamHandler.h b/src/handlers/dns/v1/DnsStreamHandler.h
@@ -171,6 +171,11 @@ class DnsMetricsBucket final : public visor::AbstractMetricsBucket
         set_num_sample_info(DNS_SCHEMA, {"wire_packets", "deep_samples"}, "Total DNS wire packets that were sampled for deep inspection");
     }
 
+    ~DnsMetricsBucket()
+    {
+        std::unique_lock lock(_mutex);
+    }
+
     auto get_xact_data_locked() const
     {
         std::shared_lock lock(_mutex);

Original file line number	Diff line number	Diff line change
`@@ -171,6 +171,11 @@ class DnsMetricsBucket final : public visor::AbstractMetricsBucket`
`171`	`171`	`set_num_sample_info(DNS_SCHEMA, {"wire_packets", "deep_samples"}, "Total DNS wire packets that were sampled for deep inspection");`
`172`	`172`	`}`
`173`	`173`
	`174`	`+ ~DnsMetricsBucket()`
	`175`	`+ {`
	`176`	`+ std::unique_lock lock(_mutex);`
	`177`	`+ }`
	`178`	`+`
`174`	`179`	`auto get_xact_data_locked() const`
`175`	`180`	`{`
`176`	`181`	`std::shared_lock lock(_mutex);`