debugger: disambiguate probe location binding

In probe mode, `--probe utils.js:10` can match multiple scripts
(e.g. `src/utils.js` and `lib/utils.js`) because the matcher uses
a path-separator-anchored URL suffix (similar to how e.g. gdb/lldb
behaves). Previously the report echoed only the user's request in
hit events, so a user seeing two hits at `utils.js:10` could not
tell which script each hit came from. In addition, previously
when the column was omitted we bound to 1 which was technically
different from how CDP binds omitted columns (to the first
executable column on the line).

This patch clarifies the semantics by tracking the scripts via
`Debugger.scriptParsed`, as recommended in the CDP docs, and
reports the actual execution location as `results[i].location`.
The same shape can be reused in the future for source maps or
additional events in attach mode.

This bumps the schema version because `target` is now
`{ suffix, line, column? }` instead of a positional array for
clarity. We picked `suffix` as the field name in case we
introduce other matching modes in the future. `column` is
omitted when the user did not supply one, and the actual
resolved column is reported in the hit event instead.

This patch also adds more tests for column-specific bindings,
multi-location resolution via require(cjs), and late script
binding via dynamic import(cjs) and require(esm).

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63286
Reviewed-By: Jan Martin <jan.krems@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Author: joyeecheung

doc/api/debugger.md

@@ -235,6 +235,13 @@ debug>
 <!-- YAML
 added:
   - v26.1.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/63286
+    description: JSON report schema bumped to v2. Probe `target` is now
+        `{ suffix, line, column? }` instead of an array. Each "hit" event carries a
+        `location` field reporting the actual evaluation location.  When the probe does not
+        specify a column, it binds to the first executable column instead of defaulting to 1.
 -->
 
 > Stability: 1 - Experimental
@@ -261,7 +268,9 @@ $ node inspect --probe <file>:<line>[:<col>] --expr <expr>
 
 * `--probe <file>:<line>[:<col>]`: Source location of the probe. When execution
   reaches the location, the provided expressions are evaluated and printed in
-  the output. Line and column numbers are 1-based. When omitted, column defaults to 1.
+  the output. `<file>` matches the URL suffix of the script to probe.
+  `<line>` and `<col>` numbers are 1-based. When `<col>` is omitted, the probe
+  binds to the first executable column on the line.
 * `--expr <expr>`: JavaScript expression to evaluate whenever execution reaches
   the location specified by the preceding `--probe`.
   Must immediately follow the `--probe` it belongs to.
@@ -313,13 +322,17 @@ Without `--json`, by default the output is printed in a human-readable text form
 
 ```console
 $ node inspect --probe cli.js:5 --expr 'rss' cli.js
-Hit 1 at cli.js:5
+Hit 1 at file:///path/to/cli.js:5:3
   rss = 54935552
-Hit 2 at cli.js:5
+Hit 2 at file:///path/to/cli.js:5:3
   rss = 55083008
 Completed
 ```
 
+The original `<file>:<line>[:<col>]` passed to `--probe` may be resolved to a different
+location to ensure it's pausable, or it can match multiple loaded scripts, so the actual
+evaluation location helps disambiguate the results.
+
 Primitive results are printed directly, while objects and arrays use Chrome
 DevTools Protocol preview data when available. Other non-primitive values
 fall back to the Chrome DevTools Protocol `description` string.
@@ -331,23 +344,39 @@ When `--json` is used, the output shape looks like this:
 
 ```console
 $ node inspect --json --probe cli.js:5 --expr 'rss' cli.js
-{"v":1,"probes":[{"expr":"rss","target":["cli.js",5]}],"results":[{"probe":0,"event":"hit","hit":1,"result":{"type":"number","value":55443456,"description":"55443456"}},{"probe":0,"event":"hit","hit":2,"result":{"type":"number","value":55574528,"description":"55574528"}},{"event":"completed"}]}
+{"v":2,"probes":[{"expr":"rss","target":{"suffix":"cli.js","line":5}}],"results":[{"probe":0,"event":"hit","hit":1,"location":{"url":"file:///path/to/cli.js","line":5,"column":3},"result":{"type":"number","value":55443456,"description":"55443456"}},{"probe":0,"event":"hit","hit":2,"location":{"url":"file:///path/to/cli.js","line":5,"column":3},"result":{"type":"number","value":55574528,"description":"55574528"}},{"event":"completed"}]}
 ```
 
 ```json
 {
-  "v": 1, // Probe JSON schema version.
+  "v": 2, // Probe JSON schema version.
   "probes": [
     {
       "expr": "rss", // The expression paired with --probe.
-      "target": ["cli.js", 5] // [file, line] or [file, line, col].
+      "target": {
+        // The user's probe specification. `suffix` is the raw <file> passed
+        // to --probe and is matched as a path-separator-anchored suffix
+        // against every loaded script's URL. `column` is present only if the
+        // user supplied `:col`. The actual evaluation location may differ
+        // from the target and will be reported in each hit's `location` field.
+        "suffix": "cli.js",
+        "line": 5
+      }
     }
   ],
   "results": [
     {
       "probe": 0, // Index into probes[].
       "event": "hit", // Hit events are recorded in observation order.
       "hit": 1, // 1-based hit count for this probe.
+      "location": {
+        // The actual location where the execution is paused to evaluate
+        // the expression of the probe. This may differ from the probe's
+        // target due to pausability adjustments or multiple matches.
+        "url": "file:///path/to/cli.js",
+        "line": 5,
+        "column": 3
+      },
       "result": {
         "type": "number",
         "value": 55443456,
@@ -359,6 +388,7 @@ $ node inspect --json --probe cli.js:5 --expr 'rss' cli.js
       "probe": 0,
       "event": "hit",
       "hit": 2,
+      "location": { "url": "file:///path/to/cli.js", "line": 5, "column": 3 },
       "result": {
         "type": "number",
         "value": 55574528,
@@ -427,9 +457,9 @@ $ node inspect --probe app.js:4 --expr 'x' --probe app.js:4 --expr 'y' -- app.js
 Prints
 
 ```text
-Hit 1 at app.js:4
+Hit 1 at file:///path/to/app.js:4:1
   x = {x: 42}
-Hit 1 at app.js:4
+Hit 1 at file:///path/to/app.js:4:1
   y = {y: 35}
 Completed
 ```
@@ -441,7 +471,7 @@ $ node inspect --probe app.js:4 --expr 'x' --probe app.js:4 --expr 'y' --json --
 Prints
 
 ```json
-{"v":1,"probes":[{"expr":"x","target":["app.js",4]},{"expr":"y","target":["app.js",4]}],"results":[{"probe":0,"event":"hit","hit":1,"result":{"type":"object","description":"Object","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"x","type":"number","value":"42"}]}}},{"probe":1,"event":"hit","hit":1,"result":{"type":"object","description":"Object","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"y","type":"number","value":"35"}]}}},{"event":"completed"}]}
+{"v":2,"probes":[{"expr":"x","target":{"suffix":"app.js","line":4}},{"expr":"y","target":{"suffix":"app.js","line":4}}],"results":[{"probe":0,"event":"hit","hit":1,"location":{"url":"file:///path/to/app.js","line":4,"column":1},"result":{"type":"object","description":"Object","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"x","type":"number","value":"42"}]}}},{"probe":1,"event":"hit","hit":1,"location":{"url":"file:///path/to/app.js","line":4,"column":1},"result":{"type":"object","description":"Object","preview":{"type":"object","description":"Object","overflow":false,"properties":[{"name":"y","type":"number","value":"35"}]}}},{"event":"completed"}]}
 ```
 
 ### Selecting the probe location
@@ -459,7 +489,7 @@ console.log(x);      // line 3
 
 ```console
 $ node inspect --probe app.js:1 --expr 'x' app.js
-Hit 1 at app.js:1
+Hit 1 at file:///path/to/app.js:1:1
   [error] x = ReferenceError: Cannot access 'x' from debugger
   ...
 Completed
@@ -469,13 +499,16 @@ Instead, probe at a location where the variable is already initialized:
 
 ```console
 $ node inspect --probe app.js:3 --expr 'x' app.js
-Hit 1 at app.js:3
+Hit 1 at file:///path/to/app.js:3:1
   x = 42
 Completed
 ```
 
-Probe paths are matched against loaded script URLs by basename, similar to how
-native debuggers typically match breakpoints. Given:
+The `<file>` argument is matched as a path suffix of every loaded
+script URL, anchored on a path separator. Passing only a basename
+matches every loaded script with that basename, similar to how native
+debuggers typically match breakpoints, while passing a partial path
+narrows the match. Given:
 
 ```text
 project/
@@ -484,7 +517,10 @@ project/
 ```
 
 `--probe utils.js:10` binds to _both_ files and produces one hit per match.
-To disambiguate, specify a fuller path that only matches the intended file:
+Each hit carries its own `location` field identifying where the expression
+was actually executed, so consumers can attribute the result to one of the
+two files accurately. To disambiguate at bind time, specify a fuller path
+that only matches the intended file:
 
 ```console
 $ node inspect --probe src/utils.js:10 --expr 'x' main.js   # matches only src/utils.js

lib/internal/debugger/inspect_helpers.js

@@ -99,9 +99,12 @@ Example:
 
 Options:
   --probe <file>:<line>[:<col>]
-                    Source location of the probe (1-based, col defaults
-                    to 1). Matches by file basename, use a fuller path to
-                    disambiguate. Must be immediately followed by --expr.
+                    Source location of the probe. <file> is matched as a
+                    path suffix of every loaded script URL, anchored on
+                    a path separator. <line> and the optional <col> are
+                    1-based. If <col> is omitted, the probe binds to
+                    the first executable column on the line. This option
+                    must be immediately followed by a pairing --expr.
   --expr <expr>     Expression to evaluate in the lexical scope of the
                     preceding --probe each time execution reaches it.
                     Avoid probing let/const-bound variables at their
@@ -114,6 +117,8 @@ Options:
 Semantics:
 * Multiple --probe/--expr pairs are allowed. Same-location --probes share
   a pause and scope, their --exprs are evaluated in command-line order.
+* --probe utils.js:<line>[:<col>] matches every loaded utils.js. Pass a
+  fuller path e.g. src/utils.js to narrow the match.
 * Use -- before any Node.js flags intended for the child process.
 * Target errors are surfaced in the report as a terminal 'error' event.
   The probing process exits 0 unless it encounters an error itself.