Skip to content

Commit 81819ad

Browse files
committed
stream: remove unnecessary check
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
1 parent 014e1f0 commit 81819ad

1 file changed

Lines changed: 9 additions & 10 deletions

File tree

lib/internal/webstreams/util.js

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,11 @@ const getNonWritablePropertyDescriptor = (value) => {
6262

6363
function extractHighWaterMark(value, defaultHWM) {
6464
if (value === undefined) return defaultHWM;
65-
value = +value;
66-
if (typeof value !== 'number' ||
67-
NumberIsNaN(value) ||
68-
value < 0)
65+
const coercedValue = +value;
66+
if (NumberIsNaN(coercedValue) ||
67+
coercedValue < 0)
6968
throw new ERR_INVALID_ARG_VALUE.RangeError('strategy.highWaterMark', value);
70-
return value;
69+
return coercedValue;
7170
}
7271

7372
function extractSizeAlgorithm(size) {
@@ -159,13 +158,13 @@ function peekQueueValue(controller) {
159158
function enqueueValueWithSize(controller, value, size) {
160159
assert(controller[kState].queue !== undefined);
161160
assert(controller[kState].queueTotalSize !== undefined);
162-
size = +size;
163-
if (typeof size !== 'number' ||
164-
size < 0 ||
165-
NumberIsNaN(size) ||
166-
size === Infinity) {
161+
const coercedSize = +size;
162+
if (NumberIsNaN(coercedSize) ||
163+
coercedSize < 0 ||
164+
coercedSize === Infinity) {
167165
throw new ERR_INVALID_ARG_VALUE.RangeError('size', size);
168166
}
167+
size = coercedSize;
169168
ArrayPrototypePush(controller[kState].queue, { value, size });
170169
controller[kState].queueTotalSize += size;
171170
}

0 commit comments

Comments
 (0)