Update review guidelines with company engagement text#94
Conversation
For addressing nodejs#92 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
@nodejs/tsc FYI, in case anyone wants to chime in |
|
What does this allow? It seems really vague to me. |
|
This now additionally allows requests for company help or engagement, for example in the linked PR. Previously, this just said "community", which I agree is a bit vague because it is unclear if we consider "companies" to be a part of it, I just tried to make it less vague by also adding "company" to it explicitly. We can further reduce the vagueness in follow up PRs. |
|
What is a "allows requests for company help"? How do you allow request from companies? Is it on a contract basis, or is this done without any money expectation? |
|
Next time I think we should wait for a response before landing this. I still don't understand the purpose of this and I don't feel comfortable with this change. |
|
This could allow both. This could also include simply asking companies to engage in posts and help in sharing feedback on stuff that mostly companies would use. For example:
Don't know if nodejs/admin#955 will land but I'm pretty sure that this part https://github.com/nodejs/admin/pull/955/files#diff-b410bd0a0f44b11a4e9468c483582530dc0ec882d53de7b90b9495f5f999e9fbR4-R5:
is not up for debate, it's a fact. Node.js exists because it is supported by people time and infrastructure. Companies are a great source of both. This change would allow us to request companies for people time and infrastructure. Then there's also monetary funding: https://github.com/nodejs/TSC/blob/main/Nodejs-Funding-Sources.md. Companies are likely the ones where the big bucks are gonna come from, so this would enable us to request companies to help out with funding. |
For addressing #92 (comment)