Skip to content

Update review guidelines with company engagement text#94

Merged
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:update-review-guidelines-with-company-engagement
Mar 15, 2025
Merged

Update review guidelines with company engagement text#94
RaisinTen merged 1 commit into
nodejs:mainfrom
RaisinTen:update-review-guidelines-with-company-engagement

Conversation

@RaisinTen
Copy link
Copy Markdown
Member

For addressing #92 (comment)

For addressing nodejs#92 (comment)

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen requested a review from a team as a code owner March 12, 2025 11:21
@RaisinTen RaisinTen mentioned this pull request Mar 12, 2025
@joyeecheung
Copy link
Copy Markdown
Member

@nodejs/tsc FYI, in case anyone wants to chime in

@anonrig
Copy link
Copy Markdown
Member

anonrig commented Mar 15, 2025

What does this allow? It seems really vague to me.

@RaisinTen
Copy link
Copy Markdown
Member Author

This now additionally allows requests for company help or engagement, for example in the linked PR. Previously, this just said "community", which I agree is a bit vague because it is unclear if we consider "companies" to be a part of it, I just tried to make it less vague by also adding "company" to it explicitly. We can further reduce the vagueness in follow up PRs.

@RaisinTen RaisinTen merged commit c7224f5 into nodejs:main Mar 15, 2025
@anonrig
Copy link
Copy Markdown
Member

anonrig commented Mar 16, 2025

What is a "allows requests for company help"? How do you allow request from companies? Is it on a contract basis, or is this done without any money expectation?

@anonrig
Copy link
Copy Markdown
Member

anonrig commented Mar 16, 2025

Next time I think we should wait for a response before landing this. I still don't understand the purpose of this and I don't feel comfortable with this change.

@RaisinTen RaisinTen deleted the update-review-guidelines-with-company-engagement branch March 17, 2025 06:47
@RaisinTen
Copy link
Copy Markdown
Member Author

This could allow both. This could also include simply asking companies to engage in posts and help in sharing feedback on stuff that mostly companies would use. For example:

  • SEAs - Based on my vision, companies are going to be a major part of the SEA userbase. Enterprise deployment of Node.js apps to customer devices where Node.js isn't installed is probably gonna be the main use case.
  • --use-system-ca - From my experience, it is needed when you want to be able to send requests in an enterprise environment where Zscaler is set up, so you would have to use the system CA instead of relying on the bundled CA or the OpenSSL CA.

Don't know if nodejs/admin#955 will land but I'm pretty sure that this part https://github.com/nodejs/admin/pull/955/files#diff-b410bd0a0f44b11a4e9468c483582530dc0ec882d53de7b90b9495f5f999e9fbR4-R5:

Sponsors support the project through people time,
infrastructure ...

is not up for debate, it's a fact. Node.js exists because it is supported by people time and infrastructure. Companies are a great source of both. This change would allow us to request companies for people time and infrastructure.

Then there's also monetary funding: https://github.com/nodejs/TSC/blob/main/Nodejs-Funding-Sources.md. Companies are likely the ones where the big bucks are gonna come from, so this would enable us to request companies to help out with funding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants