Add the missing cursor parameter to unified search requests#22422
Merged
nickvergessen merged 2 commits intomasterfrom Aug 26, 2020
Merged
Add the missing cursor parameter to unified search requests#22422nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
1 task
skjnldsv
approved these changes
Aug 25, 2020
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Wut, this was working before! 🤔
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32300: failuremysql8.0-php7.2Show full logacceptance-app-files
Show full log |
juliusknorr
approved these changes
Aug 25, 2020
Member
🙄 |
Otherwise paginated search does not work. Basically you always requested the first x items and then showed them again and again. The second or any other subsequent page was never requested. On a side note this also caused lots of Vue warning due to duplicate keys. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
d5f4176 to
97a1784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise paginated search does not work. Basically you always requested
the first x items and then showed them again and again. The second or
any other subsequent page was never requested.
On a side note this also caused lots of Vue warning due to duplicate
keys.