Merge pull request #21973 from nextcloud/techdebt/noid/fix-risky-2fa-backup-code-test

MorrisJobke · web-flow · commit f8955bd0d1fe · 2020-07-23T17:11:10.000+02:00
Fix risky test in twofactor_backupcodes
diff --git a/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php b/apps/twofactor_backupcodes/tests/Db/BackupCodeMapperTest.php
@@ -117,7 +117,12 @@ public function testInsertArgonEncryptedCodes() {
 		$code->setUserId($this->testUID);
 		$code->setCode('2|$argon2i$v=19$m=1024,t=2,p=2$MjJWUjRFWndtMm5BWGxOag$BusVxLeFyiLLWtaVvX/JRFBiPdZcjRrzpQ/rAhn6vqY');
 		$code->setUsed(1);
+		$user = $this->getMockBuilder(IUser::class)->getMock();
+		$user->expects($this->any())
+			->method('getUID')
+			->willReturn($this->testUID);
 
 		$this->mapper->insert($code);
+		$this->assertCount(1, $this->mapper->getBackupCodes($user));
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,12 @@ public function testInsertArgonEncryptedCodes() {`
`117`	`117`	`$code->setUserId($this->testUID);`
`118`	`118`	`$code->setCode('2\|$argon2i$v=19$m=1024,t=2,p=2$MjJWUjRFWndtMm5BWGxOag$BusVxLeFyiLLWtaVvX/JRFBiPdZcjRrzpQ/rAhn6vqY');`
`119`	`119`	`$code->setUsed(1);`
	`120`	`+ $user = $this->getMockBuilder(IUser::class)->getMock();`
	`121`	`+ $user->expects($this->any())`
	`122`	`+ ->method('getUID')`
	`123`	`+ ->willReturn($this->testUID);`
`120`	`124`
`121`	`125`	`$this->mapper->insert($code);`
	`126`	`+ $this->assertCount(1, $this->mapper->getBackupCodes($user));`
`122`	`127`	`}`
`123`	`128`	`}`