Merge pull request #48502 from nextcloud/backport/48426/stable29

joshtrichards · web-flow · commit da8ef3c9ea72 · 2024-10-01T14:11:23.000-04:00
[stable29] fix(config): Suppress `config.php` fopen error at install time
diff --git a/lib/private/Config.php b/lib/private/Config.php
@@ -217,7 +217,8 @@ private function readData() {
 				@opcache_invalidate($file, false);
 			}
 
-			$filePointer = @fopen($file, 'r');
+			// suppressor doesn't work here at boot time since it'll go via our onError custom error handler
+			$filePointer = file_exists($file) ? @fopen($file, 'r') : false;
 			if ($filePointer === false) {
 				// e.g. wrong permissions are set
 				if ($file === $this->configFilePath) {

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,8 @@ private function readData() {`
`217`	`217`	`@opcache_invalidate($file, false);`
`218`	`218`	`}`
`219`	`219`
`220`		`- $filePointer = @fopen($file, 'r');`
	`220`	`+ // suppressor doesn't work here at boot time since it'll go via our onError custom error handler`
	`221`	`+ $filePointer = file_exists($file) ? @fopen($file, 'r') : false;`
`221`	`222`	`if ($filePointer === false) {`
`222`	`223`	`// e.g. wrong permissions are set`
`223`	`224`	`if ($file === $this->configFilePath) {`