Update 403 error message.

camilasan · web-flow · commit d5db7bc1d2a8 · 2024-02-02T10:41:43.000+01:00
The user should get a more friendly warning when their desktop client version is not supported anymore by the server. See #nextcloud/desktop/issues/6273 Signed-off-by: Camila <hello@camilasan.com>
diff --git a/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php b/apps/dav/lib/Connector/Sabre/BlockLegacyClientPlugin.php
@@ -69,7 +69,7 @@ public function beforeHandler(RequestInterface $request) {
 		preg_match(IRequest::USER_AGENT_CLIENT_DESKTOP, $userAgent, $versionMatches);
 		if (isset($versionMatches[1]) &&
 			version_compare($versionMatches[1], $minimumSupportedDesktopVersion) === -1) {
-			throw new \Sabre\DAV\Exception\Forbidden('Unsupported client version.');
+			throw new \Sabre\DAV\Exception\Forbidden('This client is unsupported by the server: upgrade to the minimum required version '.$minimumSupportedDesktopVersion);
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public function beforeHandler(RequestInterface $request) {`
`69`	`69`	`preg_match(IRequest::USER_AGENT_CLIENT_DESKTOP, $userAgent, $versionMatches);`
`70`	`70`	`if (isset($versionMatches[1]) &&`
`71`	`71`	`version_compare($versionMatches[1], $minimumSupportedDesktopVersion) === -1) {`
`72`		`- throw new \Sabre\DAV\Exception\Forbidden('Unsupported client version.');`
	`72`	`+ throw new \Sabre\DAV\Exception\Forbidden('This client is unsupported by the server: upgrade to the minimum required version '.$minimumSupportedDesktopVersion);`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`	`}`