Merge pull request #58377 from nextcloud/backport/58285/stable32

[stable32] fix(cache): filter out invalid entries in `OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsById`

Author: susnux

build/psalm-baseline.xml

@@ -3705,12 +3705,6 @@
       <code><![CDATA[$this->cache instanceof Cache]]></code>
     </RedundantCondition>
   </file>
-  <file src="lib/private/Files/Cache/Wrapper/CacheWrapper.php">
-    <LessSpecificImplementedReturnType>
-      <code><![CDATA[array]]></code>
-      <code><![CDATA[array]]></code>
-    </LessSpecificImplementedReturnType>
-  </file>
   <file src="lib/private/Files/Config/MountProviderCollection.php">
     <InvalidOperand>
       <code><![CDATA[$user]]></code>

lib/private/Files/Cache/Wrapper/CacheWrapper.php

@@ -100,14 +100,14 @@ public function getFolderContents($folder) {
 	}
 
 	/**
-	 * get the metadata of all files stored in $folder
+	 * Get the metadata of all files stored in given folder
 	 *
 	 * @param int $fileId the file id of the folder
-	 * @return array
+	 * @return ICacheEntry[]
 	 */
 	public function getFolderContentsById($fileId) {
 		$results = $this->getCache()->getFolderContentsById($fileId);
-		return array_map([$this, 'formatCacheEntry'], $results);
+		return array_filter(array_map($this->formatCacheEntry(...), $results));
 	}
 
 	/**