fix(preview): replace TypedQueryBuilder with regular QueryBuilder for stable33 compatibility

TypedQueryBuilder and selectColumns() are not available on stable33;
replace all usages with getQueryBuilder() and select() respectively.
Update tests to mock IQueryBuilder instead of ITypedQueryBuilder.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: miaulalala

lib/private/Preview/Storage/LocalPreviewStorage.php

@@ -254,7 +254,7 @@ private function processScanBatch(
 					$pathHash = md5($relativePath);
 					if (isset($legacyByPathHash[$pathHash])) {
 						$legacyRow = $legacyByPathHash[$pathHash];
-						$qb = $this->connection->getTypedQueryBuilder();
+						$qb = $this->connection->getQueryBuilder();
 						$qb->delete('filecache')
 							->where($qb->expr()->eq('fileid', $qb->createNamedParameter($legacyRow['fileid'])))
 							->andWhere($qb->expr()->eq('storage', $qb->createNamedParameter($legacyRow['storage'])))
@@ -310,8 +310,8 @@ private function fetchFilecacheByFileIds(array $fileIds): array {
 		}
 
 		$result = [];
-		$qb = $this->connection->getTypedQueryBuilder();
-		$qb->selectColumns('fileid', 'storage', 'etag', 'mimetype')
+		$qb = $this->connection->getQueryBuilder();
+		$qb->select('fileid', 'storage', 'etag', 'mimetype')
 			->from('filecache');
 		foreach (array_chunk($fileIds, 1000) as $chunk) {
 			$qb->andWhere(
@@ -338,8 +338,8 @@ private function fetchFilecacheByPathHashes(array $pathHashes): array {
 		}
 
 		$result = [];
-		$qb = $this->connection->getTypedQueryBuilder();
-		$qb->selectColumns('fileid', 'storage', 'etag', 'mimetype', 'parent', 'path_hash')
+		$qb = $this->connection->getQueryBuilder();
+		$qb->select('fileid', 'storage', 'etag', 'mimetype', 'parent', 'path_hash')
 			->from('filecache');
 		foreach (array_chunk($pathHashes, 1000) as $chunk) {
 			$qb->andWhere(
@@ -360,8 +360,8 @@ private function fetchFilecacheByPathHashes(array $pathHashes): array {
 	 * empty.
 	 */
 	private function deleteParentsFromFileCache(int $folderId, int $storageId): void {
-		$qb = $this->connection->getTypedQueryBuilder();
-		$result = $qb->selectColumns('fileid', 'path', 'storage', 'parent')
+		$qb = $this->connection->getQueryBuilder();
+		$result = $qb->select('fileid', 'path', 'storage', 'parent')
 			->from('filecache')
 			->where($qb->expr()->eq('parent', $qb->createNamedParameter($folderId)))
 			->setMaxResults(1)
@@ -376,8 +376,8 @@ private function deleteParentsFromFileCache(int $folderId, int $storageId): void
 		}
 
 		// Get new parent
-		$qb = $this->connection->getTypedQueryBuilder();
-		$result = $qb->selectColumns('fileid', 'path', 'parent')
+		$qb = $this->connection->getQueryBuilder();
+		$result = $qb->select('fileid', 'path', 'parent')
 			->from('filecache')
 			->where($qb->expr()->eq('fileid', $qb->createNamedParameter($folderId)))
 			->andWhere($qb->expr()->eq('storage', $qb->createNamedParameter($storageId)))
@@ -388,7 +388,7 @@ private function deleteParentsFromFileCache(int $folderId, int $storageId): void
 		if ($row !== false) {
 			$parentFolderId = (int)$row['parent'];
 
-			$qb = $this->connection->getTypedQueryBuilder();
+			$qb = $this->connection->getQueryBuilder();
 			$qb->delete('filecache')
 				->where($qb->expr()->eq('fileid', $qb->createNamedParameter($folderId)))
 				->andWhere($qb->expr()->eq('storage', $qb->createNamedParameter($storageId)))

tests/lib/Preview/Storage/LocalPreviewStorageTest.php

@@ -15,7 +15,6 @@
 use OCP\DB\IResult;
 use OCP\DB\QueryBuilder\IExpressionBuilder;
 use OCP\DB\QueryBuilder\IQueryBuilder;
-use OCP\DB\QueryBuilder\ITypedQueryBuilder;
 use OCP\Files\IMimeTypeDetector;
 use OCP\Files\IMimeTypeLoader;
 use OCP\Files\IRootFolder;
@@ -124,8 +123,8 @@ private function buildQueryBuilderMock(array $rows): IQueryBuilder&MockObject {
 				return $rows[$callIndex++] ?? false;
 			});
 
-		$qbMock = $this->createMock(ITypedQueryBuilder::class);
-		$qbMock->method('selectColumns')->willReturnSelf();
+		$qbMock = $this->createMock(IQueryBuilder::class);
+		$qbMock->method('select')->willReturnSelf();
 		$qbMock->method('from')->willReturnSelf();
 		$qbMock->method('andWhere')->willReturnSelf();
 		$qbMock->method('runAcrossAllShards')->willReturnSelf();
@@ -163,7 +162,7 @@ public function testScanCommitsFinalBatch(): void {
 			'etag' => 'abc',
 			'mimetype' => '6',
 		];
-		$this->connection->method('getTypedQueryBuilder')
+		$this->connection->method('getQueryBuilder')
 			->willReturn($this->buildQueryBuilderMock([$filecacheRow]));
 
 		// Outer batch transaction + one inner savepoint for the insert.
@@ -195,7 +194,7 @@ public function testScanHandlesUniqueConstraintViolation(): void {
 			'etag' => 'abc',
 			'mimetype' => '6',
 		];
-		$this->connection->method('getTypedQueryBuilder')
+		$this->connection->method('getQueryBuilder')
 			->willReturn($this->buildQueryBuilderMock([$filecacheRow]));
 
 		$ucvException = new class('duplicate key') extends DBException {
@@ -230,7 +229,7 @@ public function testScanRethrowsUnexpectedInsertException(): void {
 			'etag' => 'abc',
 			'mimetype' => '6',
 		];
-		$this->connection->method('getTypedQueryBuilder')
+		$this->connection->method('getQueryBuilder')
 			->willReturn($this->buildQueryBuilderMock([$filecacheRow]));
 
 		$driverException = new class('some driver error') extends DBException {
@@ -270,7 +269,7 @@ public function testScanFetchesAllFilecacheRows(): void {
 			'mimetype' => '6',
 		], $fileIds);
 
-		$this->connection->method('getTypedQueryBuilder')
+		$this->connection->method('getQueryBuilder')
 			->willReturn($this->buildQueryBuilderMock($filecacheRows));
 
 		// 1 outer batch transaction + 3 inner savepoints (one per preview insert).