Skip to content

Commit a4fbe80

Browse files
authored
Merge pull request #8517 from nextcloud/stable13-8416
[stable13] Fix hiding and event propagation issues with the user management popover
2 parents a5b73fe + fef3f23 commit a4fbe80

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

settings/js/users/users.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@ $(document).ready(function () {
940940
UserList._triggerGroupEdit($td, isSubadminSelect);
941941
});
942942

943-
$userListBody.on('click', '.toggleUserActions', function (event) {
943+
$userListBody.on('click', '.toggleUserActions > .action', function (event) {
944944
event.stopPropagation();
945945
var $td = $(this).closest('td');
946946
var $tr = $($td).closest('tr');
@@ -963,9 +963,11 @@ $(document).ready(function () {
963963
$tr.addClass('active');
964964
});
965965

966-
$(document).on('mouseup', function () {
967-
$('#userlist tr.active').removeClass('active');
968-
$('#userlist .popovermenu.open').removeClass('open');
966+
$(document).on('mouseup', function (event) {
967+
if (!$(event.target).closest('.toggleUserActions').length) {
968+
$('#userlist tr.active').removeClass('active');
969+
$('#userlist .popovermenu.open').removeClass('open');
970+
}
969971
});
970972

971973
$userListBody.on('click', '.action-togglestate', function (event) {

settings/templates/users/part.userlist.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
<td class="userActions">
6868
<div class="toggleUserActions">
6969
<a class="action"><span class="icon-more"></span></a>
70-
<div class="popovermenu bubble menu">
70+
<div class="popovermenu">
7171
<ul class="userActionsMenu">
7272
<li>
7373
<a href="#" class="menuitem action-togglestate permanent" data-action="togglestate"></a>

0 commit comments

Comments
 (0)