Skip to content

Commit a4bfea7

Browse files
authored
Merge pull request #34408 from nextcloud/backport/34396/stable25
[stable25] Fix positioning of the public page footer
2 parents 1b4c821 + 1f0245e commit a4bfea7

8 files changed

Lines changed: 25 additions & 11 deletions

File tree

apps/files_sharing/css/public.css

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files_sharing/css/public.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files_sharing/css/public.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
@use 'variables';
22

33
$footer-height: 65px;
4+
$footer-padding-height: 16px;
45
$download-button-section-height: 200px;
56

67
#preview {
@@ -30,7 +31,7 @@ $download-button-section-height: 200px;
3031
}
3132

3233
#imgframe img {
33-
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height}) !important;
34+
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height} - #{$footer-padding-height}) !important;
3435
max-width: 100% !important;
3536
width: unset !important;
3637
}
@@ -40,7 +41,7 @@ $download-button-section-height: 200px;
4041
}
4142

4243
#imgframe video {
43-
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height});
44+
max-height: calc(100vh - var(--header-height) - #{$footer-height} - #{$download-button-section-height} - #{$footer-padding-height});
4445
}
4546

4647
#imgframe audio {
@@ -82,6 +83,11 @@ $download-button-section-height: 200px;
8283
max-height: 100%;
8384
}
8485

86+
87+
.app-files_sharing #app-content footer {
88+
position: sticky !important;
89+
}
90+
8591
/* fix multiselect bar offset on shared page */
8692
thead {
8793
left: 0 !important;

apps/files_sharing/css/publicView.css

Lines changed: 6 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apps/files_sharing/css/publicView.css.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/public.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

core/css/public.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ $footer-height: 65px;
6969

7070
/* public footer */
7171
footer {
72-
position: sticky !important;
72+
position: fixed;
7373
display: flex;
7474
align-items: center;
7575
justify-content: center;

core/css/server.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)