Skip to content

Commit 97bdedf

Browse files
authored
Merge pull request #29113 from nextcloud/backport/25774/stable22
[stable22] Add button color variables
2 parents d9dce2f + 8223a66 commit 97bdedf

4 files changed

Lines changed: 33 additions & 9 deletions

File tree

apps/theming/css/theming.scss

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,9 @@ input.primary,
260260

261261
/** Handle primary buttons for bright colors */
262262
@if (luma($color-primary) > 0.8) {
263+
:root {
264+
--color-primary-light-text: var(--color-primary-text);
265+
}
263266
select,
264267
button, .button,
265268
input:not([type='range']),
@@ -278,7 +281,6 @@ input.primary,
278281
}
279282
}
280283
}
281-
282284
}
283285

284286
@if ($color-primary == #ffffff) {

core/css/css-variables.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,23 @@
1818
--color-placeholder-dark: #{$color-placeholder-dark};
1919

2020
--color-primary: #{$color-primary};
21+
--color-primary-hover: #{$color-primary-hover};
2122
--color-primary-light: #{$color-primary-light};
23+
--color-primary-light-hover: #{$color-primary-light-hover};
2224
--color-primary-text: #{$color-primary-text};
25+
--color-primary-light-text: #{$color-primary-light-text};
2326
--color-primary-text-dark: #{$color-primary-text-dark};
2427
--color-primary-element: #{$color-primary-element};
28+
--color-primary-element-hover: #{$color-primary-element-hover};
2529
--color-primary-element-light: #{$color-primary-element-light};
30+
--color-primary-element-lighter: #{$color-primary-element-lighter};
2631

2732
--color-error: #{$color-error};
33+
--color-error-hover: #{$color-error-hover};
2834
--color-warning: #{$color-warning};
35+
--color-warning-hover: #{$color-warning-hover};
2936
--color-success: #{$color-success};
37+
--color-success-hover: #{$color-success-hover};
3038

3139
--color-text-maxcontrast: #{$color-text-maxcontrast};
3240
--color-text-light: #{$color-main-text};
@@ -44,6 +52,8 @@
4452

4553
--color-border: #{$color-border};
4654
--color-border-dark: #{$color-border-dark};
55+
56+
4757
--border-radius: #{$border-radius};
4858
--border-radius-large: #{$border-radius-large};
4959
--border-radius-pill: #{$border-radius-pill};
@@ -58,3 +68,4 @@
5868

5969
--header-height: #{$header-height};
6070
}
71+

core/css/inputs.scss

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $default-height: 34px;
2424

2525
/* Simple selector to allow easy overriding */
2626
select,
27-
button,
27+
button:not(.button-vue),
2828
input,
2929
textarea,
3030
div[contenteditable=true],
@@ -43,7 +43,7 @@ div[contenteditable=false] {
4343
/* Default global values */
4444
div.select2-drop .select2-search input, // TODO: REMOVE WHEN DROPPING SELECT2
4545
select,
46-
button, .button,
46+
button:not(.button-vue), .button:not(.button-vue),
4747
input:not([type='range']),
4848
textarea,
4949
div[contenteditable=true],
@@ -168,8 +168,8 @@ input {
168168

169169
/* 'Click' inputs */
170170
select,
171-
button, .button,
172-
input[type='button'],
171+
button:not(.button-vue), .button:not(.button-vue),
172+
input[type='button']:not(.button-vue),
173173
input[type='submit'],
174174
input[type='reset'] {
175175
padding: 6px 16px;
@@ -184,7 +184,7 @@ input[type='reset'] {
184184
}
185185
}
186186
select,
187-
button, .button {
187+
button:not(.button-vue), .button:not(.button-vue) {
188188
* {
189189
cursor: pointer;
190190
}
@@ -197,8 +197,8 @@ button, .button {
197197
}
198198

199199
/* Buttons */
200-
button, .button,
201-
input[type='button'],
200+
button:not(.button-vue), .button:not(.button-vue),
201+
input[type='button']:not(.button-vue),
202202
input[type='submit'],
203203
input[type='reset'] {
204204
font-weight: bold;
@@ -215,7 +215,7 @@ input[type='reset'] {
215215
color: #fff !important;
216216
}
217217
}
218-
button, .button {
218+
button:not(.button-vue), .button:not(.button-vue) {
219219
> span {
220220
/* icon position inside buttons */
221221
&[class^='icon-'],

core/css/variables.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,17 +44,27 @@ $color-placeholder-light: nc-darken($color-main-background, 10%) !default;
4444
$color-placeholder-dark: nc-darken($color-main-background, 20%) !default;
4545

4646
$color-primary: #0082c9 !default;
47+
$color-primary-hover: mix($color-primary, $color-main-background, 80%) !default;
48+
4749
$color-primary-light: mix($color-primary, $color-main-background, 10%) !default;
50+
$color-primary-light-text: $color-primary !default;
51+
$color-primary-light-hover: mix($color-primary-light, $color-main-text, 95%) !default;
52+
4853
$color-primary-text: #ffffff !default;
4954
// do not use nc-darken/lighten in case of overriding because
5055
// primary-text is independent of color-main-text
5156
$color-primary-text-dark: darken($color-primary-text, 7%) !default;
5257
$color-primary-element: $color-primary !default;
58+
$color-primary-element-hover: mix($color-primary-element, $color-main-background, 80%) !default;
5359
$color-primary-element-light: lighten($color-primary-element, 15%) !default;
60+
$color-primary-element-lighter: mix($color-primary-element, $color-main-background, 15%) !default;
5461

5562
$color-error: #e9322d;
63+
$color-error-hover: mix($color-error, $color-main-background, 80%) !default;
5664
$color-warning: #eca700;
65+
$color-warning-hover: mix($color-warning, $color-main-background, 80%) !default;
5766
$color-success: #46ba61;
67+
$color-success-hover: mix($color-success, $color-main-background, 80%) !default;
5868
// used for svg
5969
$color-white: #fff;
6070
$color-black: #000;
@@ -81,6 +91,7 @@ $color-box-shadow: transparentize(nc-darken($color-main-background, 70%), 0.5) !
8191
$color-border: nc-darken($color-main-background, 7%) !default;
8292
// darker border like inputs or very visible elements
8393
$color-border-dark: nc-darken($color-main-background, 14%) !default;
94+
8495
$border-radius: 3px !default;
8596
$border-radius-large: 10px !default;
8697
// Pill-style button, value is large so big buttons also have correct roundness

0 commit comments

Comments
 (0)