Merge pull request #48033 from nextcloud/backport/48013/stable29

skjnldsv · web-flow · commit 95c3012ca9a4 · 2024-09-15T22:54:29.000+02:00
[stable29] fix(BaseResponse): Cast XML element values to string
diff --git a/lib/private/AppFramework/OCS/BaseResponse.php b/lib/private/AppFramework/OCS/BaseResponse.php
@@ -163,8 +163,10 @@ protected function toXML(array $array, \XMLWriter $writer): void {
 				$writer->startElement($k);
 				$this->toXML($v->jsonSerialize(), $writer);
 				$writer->endElement();
+			} elseif ($v === null) {
+				$writer->writeElement($k);
 			} else {
-				$writer->writeElement($k, $v);
+				$writer->writeElement($k, (string)$v);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,10 @@ protected function toXML(array $array, \XMLWriter $writer): void {`
`163`	`163`	`$writer->startElement($k);`
`164`	`164`	`$this->toXML($v->jsonSerialize(), $writer);`
`165`	`165`	`$writer->endElement();`
	`166`	`+ } elseif ($v === null) {`
	`167`	`+ $writer->writeElement($k);`
`166`	`168`	`} else {`
`167`		`- $writer->writeElement($k, $v);`
	`169`	`+ $writer->writeElement($k, (string)$v);`
`168`	`170`	`}`
`169`	`171`	`}`
`170`	`172`	`}`