Skip to content

Commit 9342eaf

Browse files
committed
chore!(files_sharing): remove deprecated OCA.Sharing.ExternalLinkActions
This API was deprecated in Nextcloud 23. It was replaced with `OCA.Sharing.ExternalShareAction` which now have a proper API by using `registerSidebarAction` from `@nextcloud/sharing` instead. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
1 parent 2ea30f9 commit 9342eaf

3 files changed

Lines changed: 0 additions & 73 deletions

File tree

apps/files_sharing/src/components/SharingEntryLink.vue

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -192,16 +192,6 @@
192192
:file-info="fileInfo"
193193
:share="share" />
194194

195-
<!-- external legacy sharing via url (social...) -->
196-
<NcActionLink
197-
v-for="({ icon, url, name }, actionIndex) in externalLegacyLinkActions"
198-
:key="actionIndex"
199-
:href="url(shareLink)"
200-
:icon="icon"
201-
target="_blank">
202-
{{ name }}
203-
</NcActionLink>
204-
205195
<NcActionButton
206196
v-if="!isEmailShareType && canReshare"
207197
class="new-share-link"
@@ -268,7 +258,6 @@ import { toRaw } from 'vue'
268258
import NcActionButton from '@nextcloud/vue/components/NcActionButton'
269259
import NcActionCheckbox from '@nextcloud/vue/components/NcActionCheckbox'
270260
import NcActionInput from '@nextcloud/vue/components/NcActionInput'
271-
import NcActionLink from '@nextcloud/vue/components/NcActionLink'
272261
import NcActions from '@nextcloud/vue/components/NcActions'
273262
import NcActionSeparator from '@nextcloud/vue/components/NcActionSeparator'
274263
import NcActionText from '@nextcloud/vue/components/NcActionText'
@@ -301,7 +290,6 @@ export default {
301290
NcActionButton,
302291
NcActionCheckbox,
303292
NcActionInput,
304-
NcActionLink,
305293
NcActionText,
306294
NcActionSeparator,
307295
NcAvatar,
@@ -352,7 +340,6 @@ export default {
352340
// Are we waiting for password/expiration date
353341
pending: false,
354342
355-
ExternalLegacyLinkActions: OCA.Sharing.ExternalLinkActions.state,
356343
ExternalShareActions: OCA.Sharing.ExternalShareActions.state,
357344
externalShareActions: getSidebarInlineActions(),
358345
@@ -593,16 +580,6 @@ export default {
593580
return t('files_sharing', 'Copy public link of "{title}"', { title: this.title })
594581
},
595582
596-
/**
597-
* External additionnai actions for the menu
598-
*
599-
* @deprecated use OCA.Sharing.ExternalShareActions
600-
* @return {Array}
601-
*/
602-
externalLegacyLinkActions() {
603-
return this.ExternalLegacyLinkActions.actions
604-
},
605-
606583
/**
607584
* Additional actions for the menu
608585
*

apps/files_sharing/src/files_sharing_tab.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import ShareVariant from '@mdi/svg/svg/share-variant.svg?raw'
77
import { getCSPNonce } from '@nextcloud/auth'
88
import { n, t } from '@nextcloud/l10n'
99
import Vue from 'vue'
10-
import ExternalLinkActions from './services/ExternalLinkActions.js'
1110
import ExternalShareActions from './services/ExternalShareActions.js'
1211
import ShareSearch from './services/ShareSearch.js'
1312
import TabSections from './services/TabSections.js'
@@ -19,7 +18,6 @@ if (!window.OCA.Sharing) {
1918
window.OCA.Sharing = {}
2019
}
2120
Object.assign(window.OCA.Sharing, { ShareSearch: new ShareSearch() })
22-
Object.assign(window.OCA.Sharing, { ExternalLinkActions: new ExternalLinkActions() })
2321
Object.assign(window.OCA.Sharing, { ExternalShareActions: new ExternalShareActions() })
2422
Object.assign(window.OCA.Sharing, { ShareTabSections: new TabSections() })
2523

apps/files_sharing/src/services/ExternalLinkActions.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

0 commit comments

Comments
 (0)