fix: filter out contacts with invalid email addresses in sharee completion

juliusknorr · juliusknorr · commit 87e12884c6c2 · 2025-03-25T23:35:44.000+01:00
Signed-off-by: Julius Knorr &lt;jus@bitgrid.net&gt;
diff --git a/lib/private/Collaboration/Collaborators/MailPlugin.php b/lib/private/Collaboration/Collaborators/MailPlugin.php
@@ -100,6 +100,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
 						$emailAddress = $emailAddressData['value'];
 						$emailAddressType = $emailAddressData['type'];
 					}
+
+					if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
+						continue;
+					}
+
 					if (isset($contact['FN'])) {
 						$displayName = $contact['FN'] . ' (' . $emailAddress . ')';
 					}

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b`
`100`	`100`	`$emailAddress = $emailAddressData['value'];`
`101`	`101`	`$emailAddressType = $emailAddressData['type'];`
`102`	`102`	`}`
	`103`	`+`
	`104`	`+ if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {`
	`105`	`+ continue;`
	`106`	`+ }`
	`107`	`+`
`103`	`108`	`if (isset($contact['FN'])) {`
`104`	`109`	`$displayName = $contact['FN'] . ' (' . $emailAddress . ')';`
`105`	`110`	`}`