Skip to content

Commit 7412cb0

Browse files
authored
Merge pull request #43403 from nextcloud/backport/43369/stable28
[stable28] fix: added last two places for aria-labels on setting icons
2 parents 2f6b641 + 4b40638 commit 7412cb0

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

apps/settings/templates/settings/admin/additional-mail.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,11 @@
5353
<div class="section" id="mail_general_settings">
5454
<form id="mail_general_settings_form" class="mail_settings">
5555
<h2><?php p($l->t('Email server'));?></h2>
56-
<a target="_blank" rel="noreferrer noopener" class="icon-info"
57-
title="<?php p($l->t('Open documentation'));?>"
58-
href="<?php p(link_to_docs('admin-email')); ?>"></a>
56+
<a target="_blank"
57+
rel="noreferrer noopener" class="icon-info"
58+
title="<?php p($l->t('Open documentation'));?>"
59+
href="<?php p(link_to_docs('admin-email')); ?>"
60+
aria-label="<?php p($l->t('Open documentation'));?>"></a>
5961
<p class="settings-hint">
6062
<?php p($l->t('It is important to set up this server to be able to send emails, like for password reset and notifications.')); ?>
6163
</p>

apps/settings/templates/settings/admin/overview.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@
3030
<div id="security-warning" class="section">
3131
<div class="security-warning__heading">
3232
<h2><?php p($l->t('Security & setup warnings'));?></h2>
33-
<a target="_blank" rel="noreferrer" class="icon-info" title="<?php p($l->t('Open documentation'));?>" href="<?php p(link_to_docs('admin-warnings')); ?>"></a>
33+
<a target="_blank"
34+
rel="noreferrer"
35+
class="icon-info"
36+
title="<?php p($l->t('Open documentation'));?>"
37+
href="<?php p(link_to_docs('admin-warnings')); ?>"
38+
aria-label="<?php p($l->t('Open documentation')); ?>"></a>
3439
</div>
3540
<p class="settings-hint"><?php p($l->t('It\'s important for the security and performance of your instance that everything is configured correctly. To help you with that we are doing some automatic checks. Please see the linked documentation for more information.'));?></p>
3641

0 commit comments

Comments
 (0)