Skip to content

Commit 6d06385

Browse files
committed
Add border color variable for increased contrast instead of changing decorative border colors
Signed-off-by: Christopher Ng <chrng8@gmail.com>
1 parent a51f0db commit 6d06385

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

apps/theming/css/default.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@
3030
--color-loading-dark: #444444;
3131
--color-box-shadow-rgb: 77,77,77;
3232
--color-box-shadow: rgba(var(--color-box-shadow-rgb), 0.5);
33-
--color-border: #949494;
34-
--color-border-dark: #808080;
33+
--color-border: #ededed;
34+
--color-border-dark: #dbdbdb;
35+
--color-border-maxcontrast: #949494;
3536
--font-face: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', Arial, sans-serif, 'Noto Color Emoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol';
3637
--default-font-size: 15px;
3738
--animation-quick: 100ms;

apps/theming/lib/Themes/DarkTheme.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,9 @@ public function getCSSVariables(): array {
8989
'--color-box-shadow' => $colorBoxShadow,
9090
'--color-box-shadow-rgb' => $colorBoxShadowRGB,
9191

92-
'--color-border' => $this->util->lighten($colorMainBackground, 30),
93-
'--color-border-dark' => $this->util->lighten($colorMainBackground, 38),
92+
'--color-border' => $this->util->lighten($colorMainBackground, 7),
93+
'--color-border-dark' => $this->util->lighten($colorMainBackground, 14),
94+
'--color-border-maxcontrast' => $this->util->lighten($colorMainBackground, 30),
9495

9596
'--background-invert-if-dark' => 'invert(100%)',
9697
'--background-invert-if-bright' => 'no',

apps/theming/lib/Themes/DefaultTheme.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,9 @@ public function getCSSVariables(): array {
155155
'--color-box-shadow-rgb' => $colorBoxShadowRGB,
156156
'--color-box-shadow' => "rgba(var(--color-box-shadow-rgb), 0.5)",
157157

158-
'--color-border' => $this->util->darken($colorMainBackground, 42),
159-
'--color-border-dark' => $this->util->darken($colorMainBackground, 50),
158+
'--color-border' => $this->util->darken($colorMainBackground, 7),
159+
'--color-border-dark' => $this->util->darken($colorMainBackground, 14),
160+
'--color-border-maxcontrast' => $this->util->darken($colorMainBackground, 42),
160161

161162
'--font-face' => "-apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', Arial, sans-serif, 'Noto Color Emoji', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'",
162163
'--default-font-size' => '15px',

0 commit comments

Comments
 (0)