Skip to content

Commit 6910832

Browse files
summersabskjnldsv
authored andcommitted
Refactor OC\Server::getCommentsManager
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
1 parent df1cd1b commit 6910832

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

lib/private/User/User.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
use OC\Hooks\Emitter;
4141
use OC_Helper;
4242
use OCP\Accounts\IAccountManager;
43+
use OCP\Comments\ICommentsManager;
4344
use OCP\EventDispatcher\IEventDispatcher;
4445
use OCP\Group\Events\BeforeUserRemovedEvent;
4546
use OCP\Group\Events\UserRemovedEvent;
@@ -290,8 +291,8 @@ public function delete() {
290291
// Delete the user's keys in preferences
291292
\OC::$server->getConfig()->deleteAllUserValues($this->uid);
292293

293-
\OC::$server->getCommentsManager()->deleteReferencesOfActor('users', $this->uid);
294-
\OC::$server->getCommentsManager()->deleteReadMarksFromUser($this);
294+
\OC::$server->get(ICommentsManager::class)->deleteReferencesOfActor('users', $this->uid);
295+
\OC::$server->get(ICommentsManager::class)->deleteReadMarksFromUser($this);
295296

296297
/** @var AvatarManager $avatarManager */
297298
$avatarManager = \OCP\Server::get(AvatarManager::class);

tests/lib/Comments/ManagerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ public function testDeleteReferencesOfActorWithUserManagement() {
668668
$user = \OC::$server->getUserManager()->createUser('xenia', '123456');
669669
$this->assertTrue($user instanceof IUser);
670670

671-
$manager = \OC::$server->getCommentsManager();
671+
$manager = \OC::$server->get(ICommentsManager::class);
672672
$comment = $manager->create('users', $user->getUID(), 'files', 'file64');
673673
$comment
674674
->setMessage('Most important comment I ever left on the Internet.')

tests/lib/ServerTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626

2727
use OC\App\AppStore\Fetcher\AppFetcher;
2828
use OC\App\AppStore\Fetcher\CategoryFetcher;
29+
use OCP\Comments\ICommentsManager;
2930

3031
/**
3132
* Class Server
@@ -185,7 +186,7 @@ public function testOverwriteDefaultCommentsManager() {
185186

186187
$config->setSystemValue('comments.managerFactory', '\Test\Comments\FakeFactory');
187188

188-
$manager = $this->server->getCommentsManager();
189+
$manager = $this->server->get(ICommentsManager::class);
189190
$this->assertInstanceOf('\OCP\Comments\ICommentsManager', $manager);
190191

191192
$config->setSystemValue('comments.managerFactory', $defaultManagerFactory);

0 commit comments

Comments
 (0)